Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add pure_pursuit as lateral controller into launch files #750

Merged
merged 4 commits into from
Apr 22, 2022

Conversation

brkay54
Copy link
Member

@brkay54 brkay54 commented Apr 21, 2022

Description

Closes (#749)
Related (#567)
tier4_control_launch/launch/control.launch.py lateral_controller_mode option is not working.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@brkay54 brkay54 self-assigned this Apr 21, 2022
@brkay54 brkay54 added the type:bug Software flaws or errors. label Apr 21, 2022
@brkay54 brkay54 changed the title add pure_pursuit as lateral controller into launch files fix: add pure_pursuit as lateral controller into launch files Apr 21, 2022
@codecov
Copy link

codecov bot commented Apr 21, 2022

Codecov Report

Merging #750 (1320ae0) into main (32502db) will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##            main    #750   +/-   ##
=====================================
  Coverage   9.63%   9.63%           
=====================================
  Files        907     907           
  Lines      56518   56518           
  Branches    6694    6694           
=====================================
  Hits        5448    5448           
  Misses     46575   46575           
  Partials    4495    4495           
Flag Coverage Δ *Carryforward flag
differential 0.00% <ø> (?)
total 9.63% <ø> (ø) Carriedforward from fe3c2a2

*This pull request uses carry forward flags. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 32502db...1320ae0. Read the comment docs.

@brkay54 brkay54 requested a review from TakaHoribe April 21, 2022 13:56
isamu-takagi pushed a commit to isamu-takagi/autoware.universe that referenced this pull request Apr 21, 2022
…n#128)

* fix topic name described in README

* fix readme.md

Signed-off-by: wep21 <[email protected]>

Co-authored-by: Taichi Hirano <[email protected]>
Copy link
Contributor

@maxime-clem maxime-clem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and it works well.
I only have minor comments about some comments in the code.

@brkay54
Copy link
Member Author

brkay54 commented Apr 22, 2022

@xmfcx Can you merge please?

@xmfcx xmfcx merged commit 5653ae4 into autowarefoundation:main Apr 22, 2022
@brkay54 brkay54 deleted the add-pure-pursuit-to-launch branch April 25, 2022 11:58
boyali referenced this pull request in boyali/autoware.universe Sep 28, 2022
boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022
boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022
boyali referenced this pull request in boyali/autoware.universe Oct 19, 2022
kyoichi-sugahara pushed a commit to kyoichi-sugahara/autoware.universe that referenced this pull request Aug 28, 2023
…ivable-area-expansion-when-lane-change

fix(behavior_path_planner): add fallback for splitting the dynamic drivable area into left and right bounds (autowarefoundation#4646)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Software flaws or errors.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants