-
Notifications
You must be signed in to change notification settings - Fork 640
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(net_monitor): fix cppcheck warnings #7573
Conversation
Signed-off-by: Ryuta Kambe <[email protected]>
Signed-off-by: Ryuta Kambe <[email protected]>
Signed-off-by: Ryuta Kambe <[email protected]>
Signed-off-by: Ryuta Kambe <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7573 +/- ##
==========================================
- Coverage 14.84% 0.00% -14.85%
==========================================
Files 1999 54 -1945
Lines 139163 4014 -135149
Branches 43716 440 -43276
==========================================
- Hits 20661 0 -20661
+ Misses 95731 4014 -91717
+ Partials 22771 0 -22771
☔ View full report in Codecov by Sentry. |
Signed-off-by: Ryuta Kambe <[email protected]>
@ito-san @TetsuKawa |
@veqcc checking if the corrections are working properly, so please wait. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@veqcc
Verified it works correctly. Thanks!
* fix unusedVariable warning Signed-off-by: Ryuta Kambe <[email protected]> * fix unusedVariable warning Signed-off-by: Ryuta Kambe <[email protected]> * fix variableScope warning Signed-off-by: Ryuta Kambe <[email protected]> * fix unreadVariable warning Signed-off-by: Ryuta Kambe <[email protected]> * fix Signed-off-by: Ryuta Kambe <[email protected]> --------- Signed-off-by: Ryuta Kambe <[email protected]> Signed-off-by: Simon Eisenmann <[email protected]>
* fix unusedVariable warning Signed-off-by: Ryuta Kambe <[email protected]> * fix unusedVariable warning Signed-off-by: Ryuta Kambe <[email protected]> * fix variableScope warning Signed-off-by: Ryuta Kambe <[email protected]> * fix unreadVariable warning Signed-off-by: Ryuta Kambe <[email protected]> * fix Signed-off-by: Ryuta Kambe <[email protected]> --------- Signed-off-by: Ryuta Kambe <[email protected]>
Description
This is a fix based on cppcheck warnings below
Tests performed
Not applicable.
Effects on system behavior
Not applicable.
Interface changes
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.