Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(euclidean_cluster): fix euclidean cluster params #7662

Merged
merged 9 commits into from
Jul 1, 2024

style(pre-commit): autofix

8810607
Select commit
Loading
Failed to load commit list.
Merged

fix(euclidean_cluster): fix euclidean cluster params #7662

style(pre-commit): autofix
8810607
Select commit
Loading
Failed to load commit list.
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main) succeeded Jun 24, 2024 in 37s

CodeScene PR Check

✅ Code Health Quality Gates: OK

  • Declining Code Health: 1 findings(s) 🚩

View detailed results in CodeScene

Details

🚩 Declining Code Health (highest to lowest):

  • Complex Method voxel_grid_based_euclidean_cluster.cpp: VoxelGridBasedEuclideanCluster::cluster

Annotations

Check warning on line 130 in perception/euclidean_cluster/lib/voxel_grid_based_euclidean_cluster.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ Getting worse: Complex Method 

VoxelGridBasedEuclideanCluster::cluster increases in cyclomatic complexity from 12 to 13, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
View more details on CodeScene Delta Analysis