fix(pose_instability_detector): fix a rare error #7681
Merged
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main)
failed
Jun 27, 2024 in 31s
CodeScene PR Check
❌ Code Health Quality Gates: FAILED
- Declining Code Health: 1 findings(s) 🚩
- Improving Code Health: 1 findings(s) ✅
Details
🚩 Declining Code Health (highest to lowest):
- Complex Method pose_instability_detector.cpp: PoseInstabilityDetector::clip_out_necessary_twist
✅ Improving Code Health:
- Large Method pose_instability_detector.cpp: PoseInstabilityDetector::clip_out_necessary_twist
Annotations
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
❌ New issue: Complex Method
PoseInstabilityDetector::clip_out_necessary_twist has a cyclomatic complexity of 10, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
Check notice on line 388 in localization/pose_instability_detector/src/pose_instability_detector.cpp
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
ℹ Getting worse: Bumpy Road Ahead
PoseInstabilityDetector::clip_out_necessary_twist increases from 2 to 4 logical blocks with deeply nested code, threshold is one single block per function. The Bumpy Road code smell is a function that contains multiple chunks of nested conditional logic. The deeper the nesting and the more bumps, the lower the code health.
Check notice on line 1 in localization/pose_instability_detector/src/pose_instability_detector.cpp
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
✅ No longer an issue: Large Method
PoseInstabilityDetector::clip_out_necessary_twist is no longer above the threshold for lines of code
Loading