-
Notifications
You must be signed in to change notification settings - Fork 639
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(autonomous_emergency_braking): aeb strange mpc polygon #7740
fix(autonomous_emergency_braking): aeb strange mpc polygon #7740
Conversation
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
Signed-off-by: Daniel Sanchez <[email protected]>
d9e3eaf
to
5fdb157
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7740 +/- ##
==========================================
- Coverage 15.09% 0.00% -15.10%
==========================================
Files 1967 118 -1849
Lines 135941 12777 -123164
Branches 42122 1379 -40743
==========================================
- Hits 20520 0 -20520
+ Misses 92700 12777 -79923
+ Partials 22721 0 -22721
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OMG!
edfeedd
into
autowarefoundation:main
…oundation#7740) change resize to reserve Signed-off-by: Daniel Sanchez <[email protected]>
…oundation#7740) change resize to reserve Signed-off-by: Daniel Sanchez <[email protected]> Signed-off-by: palas21 <[email protected]>
…oundation#7740) change resize to reserve Signed-off-by: Daniel Sanchez <[email protected]>
change resize to reserve Signed-off-by: Daniel Sanchez <[email protected]>
…oundation#7740) change resize to reserve Signed-off-by: Daniel Sanchez <[email protected]>
Description
Due to the use of resize() the path vector generates a vector full of path points with position x:0 y:0 z:0 . This causes the AEB module to generate a wrong polygon path (because the last path poses are located at the base link).
This PR fixes the issue by doing reserve() instead, which seems like the original intention of the original commit.
Related links
Parent Issue:
How was this PR tested?
Before:
The polygon is disjointed and an NPC is wrongly detected as an obstacle.
After:
The polygons are correct and no collision is detected!
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.