Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(clang-tidy): test if workflow fails only when it reports errors #7749

Closed
wants to merge 5 commits into from
Closed

test(clang-tidy): test if workflow fails only when it reports errors #7749

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c6476d8
test(clang-tidy): test if workflow fails only when it reports errors
xmfcx Jun 28, 2024
b25cf26
add dummy change
xmfcx Jun 28, 2024
93f102f
test for success
xmfcx Jun 28, 2024
3474eed
a
xmfcx Jun 28, 2024
fa2be66
test: clang-tidy differential will fail
veqcc Jul 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/build-and-test-differential.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@

- name: Export CUDA state as a variable for adding to cache key
run: |
build_type_cuda_state=nocuda

Check warning on line 79 in .github/workflows/build-and-test-differential.yaml

View workflow job for this annotation

GitHub Actions / spell-check-differential 

Unknown word (nocuda)
if [[ "${{ matrix.container-suffix }}" == "-cuda" ]]; then
build_type_cuda_state=cuda
fi
Expand Down Expand Up @@ -150,7 +150,7 @@

- name: Run clang-tidy
if: ${{ steps.get-changed-files.outputs.changed-files != '' }}
uses: autowarefoundation/autoware-github-actions/clang-tidy@v1
uses: autowarefoundation/autoware-github-actions/clang-tidy@fix/clang-tidy
with:
rosdistro: humble
target-packages: ${{ steps.get-modified-packages.outputs.modified-packages }}
Expand Down
2 changes: 2 additions & 0 deletions ...ehavior_path_planner/autoware_behavior_path_avoidance_by_lane_change_module/src/scene.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,8 @@ using autoware::behavior_path_planner::Point2d;
using autoware::behavior_path_planner::utils::lane_change::debug::createExecutionArea;
namespace utils = autoware::behavior_path_planner::utils;

// TODO(veqcc): remove this comment line.

AvoidanceByLaneChange::AvoidanceByLaneChange(
const std::shared_ptr<LaneChangeParameters> & parameters,
std::shared_ptr<AvoidanceByLCParameters> avoidance_parameters)
Expand Down
Loading