-
Notifications
You must be signed in to change notification settings - Fork 639
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: ml detector buffer capacity and parameterization #7936
fix: ml detector buffer capacity and parameterization #7936
Conversation
…e to new models) but parameterized to users can adapt it to their use cases Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]>
Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]>
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7936 +/- ##
==========================================
- Coverage 28.95% 28.95% -0.01%
==========================================
Files 1606 1607 +1
Lines 117597 117617 +20
Branches 50602 50605 +3
==========================================
+ Hits 34048 34051 +3
- Misses 74299 74316 +17
Partials 9250 9250
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your PR! Apart of tiny typos it looks good!
Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]>
@kminoda @tzhong518 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…tion#7936) * fix: increased the buffer capacity in ML-based detectors (1M -> 2M due to new models) but parameterized to users can adapt it to their use cases Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]> * chore: added schema parts Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]> * chore: points are countable ! Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]> --------- Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]> Signed-off-by: Y.Hisaki <[email protected]>
…tion#7936) * fix: increased the buffer capacity in ML-based detectors (1M -> 2M due to new models) but parameterized to users can adapt it to their use cases Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]> * chore: added schema parts Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]> * chore: points are countable ! Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]> --------- Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]>
…tion#7936) * fix: increased the buffer capacity in ML-based detectors (1M -> 2M due to new models) but parameterized to users can adapt it to their use cases Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]> * chore: added schema parts Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]> * chore: points are countable ! Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]> --------- Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]> Signed-off-by: chtseng <[email protected]>
…tion#7936) * fix: increased the buffer capacity in ML-based detectors (1M -> 2M due to new models) but parameterized to users can adapt it to their use cases Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]> * chore: added schema parts Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]> * chore: points are countable ! Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]> --------- Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]>
…tion#7936) * fix: increased the buffer capacity in ML-based detectors (1M -> 2M due to new models) but parameterized to users can adapt it to their use cases Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]> * chore: added schema parts Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]> * chore: points are countable ! Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]> --------- Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]>
Description
In some vehicle setups, the current 1M points was not enough in the ML object detectors.
In this PR I increased it to 2M while also making it a parameter so that users can adapt it to their use cases
Related links
How was this PR tested?
Launcher autoware and verified that the parameter was loaded correctly
Notes for reviewers
This PR must be merged with its
autoware_launch
companion (autowarefoundation/autoware_launch#1067)None.
Interface changes
None.
Effects on system behavior
None.