fix: ml detector buffer capacity and parameterization #7936
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e to new models) but parameterized to users can adapt it to their use cases Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]>
Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]>
knzo25
requested review from
amadeuszsz,
scepter914,
kminoda,
badai-nguyen,
ktro2828,
miursh,
tzhong518,
YoshiRi and
yukkysaito
as code owners
github-actions
bot
added
the
component:perception
|
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
This was referenced Jul 10, 2024
Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]>
knzo25
added
the
tag:run-build-and-test-differential
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7936 +/- ##
==========================================
- Coverage 28.95% 28.95% -0.01%
==========================================
Files 1606 1607 +1
Lines 117597 117617 +20
Branches 50602 50605 +3
==========================================
+ Hits 34048 34051 +3
- Misses 74299 74316 +17
Partials 9250 9250
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
amadeuszsz
requested changes
Jul 10, 2024
Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]>
amadeuszsz
approved these changes
Jul 10, 2024
|
@kminoda @tzhong518 |
yhisaki
pushed a commit
to yhisaki/autoware.universe
that referenced
this pull request
Jul 19, 2024
…tion#7936) * fix: increased the buffer capacity in ML-based detectors (1M -> 2M due to new models) but parameterized to users can adapt it to their use cases Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]> * chore: added schema parts Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]> * chore: points are countable ! Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]> --------- Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]> Signed-off-by: Y.Hisaki <[email protected]>
Ariiees
pushed a commit
to Ariiees/autoware.universe
that referenced
this pull request
Jul 22, 2024
…tion#7936) * fix: increased the buffer capacity in ML-based detectors (1M -> 2M due to new models) but parameterized to users can adapt it to their use cases Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]> * chore: added schema parts Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]> * chore: points are countable ! Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]> --------- Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]>
chihungtzeng
pushed a commit
to chihungtzeng/autoware.universe
that referenced
this pull request
Jul 23, 2024
…tion#7936) * fix: increased the buffer capacity in ML-based detectors (1M -> 2M due to new models) but parameterized to users can adapt it to their use cases Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]> * chore: added schema parts Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]> * chore: points are countable ! Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]> --------- Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]> Signed-off-by: chtseng <[email protected]>
TomohitoAndo
pushed a commit
to tier4/autoware.universe
that referenced
this pull request
Sep 19, 2024
…tion#7936) * fix: increased the buffer capacity in ML-based detectors (1M -> 2M due to new models) but parameterized to users can adapt it to their use cases Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]> * chore: added schema parts Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]> * chore: points are countable ! Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]> --------- Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]>
TomohitoAndo
pushed a commit
to tier4/autoware.universe
that referenced
this pull request
Sep 19, 2024
…tion#7936) * fix: increased the buffer capacity in ML-based detectors (1M -> 2M due to new models) but parameterized to users can adapt it to their use cases Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]> * chore: added schema parts Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]> * chore: points are countable ! Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]> --------- Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]>
This was referenced Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In some vehicle setups, the current 1M points was not enough in the ML object detectors.
In this PR I increased it to 2M while also making it a parameter so that users can adapt it to their use cases
Related links
How was this PR tested?
Launcher autoware and verified that the parameter was loaded correctly
Notes for reviewers
This PR must be merged with its
autoware_launchcompanion (autowarefoundation/autoware_launch#1067)None.
Interface changes
None.
Effects on system behavior
None.