-
Notifications
You must be signed in to change notification settings - Fork 639
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(pose_estimator_arbiter)!: prefix package and namespace with autoware #8386
refactor(pose_estimator_arbiter)!: prefix package and namespace with autoware #8386
Conversation
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
@a-maumau |
Signed-off-by: a-maumau <[email protected]>
Signed-off-by: a-maumau <[email protected]>
797c0f0
to
b520cf1
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8386 +/- ##
==========================================
+ Coverage 24.01% 24.07% +0.05%
==========================================
Files 1384 1396 +12
Lines 102177 101271 -906
Branches 38945 38516 -429
==========================================
- Hits 24540 24381 -159
+ Misses 75141 74366 -775
- Partials 2496 2524 +28
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The CI check has not yet passed.
Signed-off-by: a-maumau <[email protected]>
I updated the source to pass the cppcheck. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have confirmed that logging_simulator works well and the mean error against AWSIM GT is roughly the same as before.
-
Directory Name
- Add
autoware_
as a prefix to the directory name.
- Add
-
packages.xml
- Add
autoware_
to thename
element.
- Add
-
CMakeLists.txt
- Change the
project
name toautoware_***
. - Add
autoware::
toPLUGIN
.
- Change the
-
Header Files (.hpp)
- Fix
#ifndef
include guards - Add
autoware::
tonamespace
.
- Fix
-
Source Files (.cpp)
- Add
autoware::
insideRCLCPP_COMPONENTS_REGISTER_NODE
.
- Add
-
Launch Files
- Add
autoware_
beforefind-pkg-share
. - Change
node pkg="<pkgname>"
toautoware_<pkgname>
.
- Add
-
Verification Points
- Search
find-pkg-share
in autoware - Check README file (especially json schema)
- Search
…autoware (autowarefoundation#8386) * add autoware_ prefix Signed-off-by: a-maumau <[email protected]> * add autoware_ prefix Signed-off-by: a-maumau <[email protected]> * fix link for landmark_based_localizer Signed-off-by: a-maumau <[email protected]> * remove Shadowing Signed-off-by: a-maumau <[email protected]> --------- Signed-off-by: a-maumau <[email protected]> Co-authored-by: SakodaShintaro <[email protected]>
…autoware (autowarefoundation#8386) * add autoware_ prefix Signed-off-by: a-maumau <[email protected]> * add autoware_ prefix Signed-off-by: a-maumau <[email protected]> * fix link for landmark_based_localizer Signed-off-by: a-maumau <[email protected]> * remove Shadowing Signed-off-by: a-maumau <[email protected]> --------- Signed-off-by: a-maumau <[email protected]> Co-authored-by: SakodaShintaro <[email protected]>
Description
This PR will add a
autoware_
prefix topose_estimator_arbiter
.Related links
Parent Issue:
How was this PR tested?
Checked the node is launching or not with
ros2 launch autoware_launch logging_simulator.launch.xml map_path:=$HOME/to/map vehicle_model:=sample_vehicle sensor_model:=awsim_sensor_kit pose_source:=ndt_yabloc_eagleye_artag
.Did not check the functionality.
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.