Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(pose_estimator_arbiter)!: prefix package and namespace with autoware #8386

Conversation

a-maumau
Copy link
Contributor

@a-maumau a-maumau commented Aug 7, 2024

Description

This PR will add a autoware_ prefix to pose_estimator_arbiter.

Related links

Parent Issue:

How was this PR tested?

Checked the node is launching or not with ros2 launch autoware_launch logging_simulator.launch.xml map_path:=$HOME/to/map vehicle_model:=sample_vehicle sensor_model:=awsim_sensor_kit pose_source:=ndt_yabloc_eagleye_artag.

Did not check the functionality.

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:localization Vehicle's position determination in its environment. (auto-assigned) component:launch Launch files, scripts and initialization tools. (auto-assigned) labels Aug 7, 2024
Copy link

github-actions bot commented Aug 7, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@SakodaShintaro SakodaShintaro added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Aug 9, 2024
@SakodaShintaro
Copy link
Contributor

@a-maumau
Unfortunately, some CI checks failed.
Could you check the cppcheck-differential and pre-commit-optional?
It may be better to make another pull request to only fix cppcheck-differential's error.

Copy link

codecov bot commented Aug 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 24.07%. Comparing base (c5e8062) to head (a2b3087).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8386      +/-   ##
==========================================
+ Coverage   24.01%   24.07%   +0.05%     
==========================================
  Files        1384     1396      +12     
  Lines      102177   101271     -906     
  Branches    38945    38516     -429     
==========================================
- Hits        24540    24381     -159     
+ Misses      75141    74366     -775     
- Partials     2496     2524      +28     
Flag Coverage Δ *Carryforward flag
differential 18.20% <100.00%> (?)
total 23.94% <ø> (-0.08%) ⬇️ Carriedforward from 19e3fb2

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@SakodaShintaro SakodaShintaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CI check has not yet passed.

Signed-off-by: a-maumau <[email protected]>
@a-maumau
Copy link
Contributor Author

I updated the source to pass the cppcheck.

Copy link
Contributor

@SakodaShintaro SakodaShintaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have confirmed that logging_simulator works well and the mean error against AWSIM GT is roughly the same as before.

  • Directory Name

    • Add autoware_ as a prefix to the directory name.
  • packages.xml

    • Add autoware_ to the name element.
  • CMakeLists.txt

    • Change the project name to autoware_***.
    • Add autoware:: to PLUGIN.
  • Header Files (.hpp)

    • Fix #ifndef include guards
    • Add autoware:: to namespace.
  • Source Files (.cpp)

    • Add autoware:: inside RCLCPP_COMPONENTS_REGISTER_NODE.
  • Launch Files

    • Add autoware_ before find-pkg-share.
    • Change node pkg="<pkgname>" to autoware_<pkgname>.
  • Verification Points

    • Search find-pkg-share in autoware
    • Check README file (especially json schema)

@SakodaShintaro SakodaShintaro merged commit 68f2b95 into autowarefoundation:main Aug 22, 2024
31 checks passed
kyoichi-sugahara pushed a commit to kyoichi-sugahara/autoware.universe that referenced this pull request Aug 27, 2024
…autoware (autowarefoundation#8386)

* add autoware_ prefix

Signed-off-by: a-maumau <[email protected]>

* add autoware_ prefix

Signed-off-by: a-maumau <[email protected]>

* fix link for landmark_based_localizer

Signed-off-by: a-maumau <[email protected]>

* remove Shadowing

Signed-off-by: a-maumau <[email protected]>

---------

Signed-off-by: a-maumau <[email protected]>
Co-authored-by: SakodaShintaro <[email protected]>
a-maumau added a commit to a-maumau/autoware.universe that referenced this pull request Sep 2, 2024
…autoware (autowarefoundation#8386)

* add autoware_ prefix

Signed-off-by: a-maumau <[email protected]>

* add autoware_ prefix

Signed-off-by: a-maumau <[email protected]>

* fix link for landmark_based_localizer

Signed-off-by: a-maumau <[email protected]>

* remove Shadowing

Signed-off-by: a-maumau <[email protected]>

---------

Signed-off-by: a-maumau <[email protected]>
Co-authored-by: SakodaShintaro <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:launch Launch files, scripts and initialization tools. (auto-assigned) component:localization Vehicle's position determination in its environment. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants