Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(map_height_fitter)!: prefix package and namespace with autoware #8421

Merged

Conversation

a-maumau
Copy link
Contributor

@a-maumau a-maumau commented Aug 9, 2024

Description

This PR will add the autoware_ prefix to map_height_fitter.

This will affect driving_log_replayer

Related links

Parent Issue:

How was this PR tested?

  • Checked the node launched

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

Signed-off-by: a-maumau <[email protected]>
@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:localization Vehicle's position determination in its environment. (auto-assigned) component:system System design and integration. (auto-assigned) component:map Map creation, storage, and loading. (auto-assigned) type:ci Continuous Integration (CI) processes and testing. (auto-assigned) labels Aug 9, 2024
Copy link

github-actions bot commented Aug 9, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

Copy link

codecov bot commented Aug 14, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 23.91%. Comparing base (a7db560) to head (52d6fa5).
Report is 25 commits behind head on main.

Files Patch % Lines
...e_map_height_fitter/src/map_height_fitter_node.cpp 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8421      +/-   ##
==========================================
- Coverage   23.96%   23.91%   -0.05%     
==========================================
  Files        1382     1388       +6     
  Lines      102019   102185     +166     
  Branches    38886    38899      +13     
==========================================
- Hits        24446    24437       -9     
- Misses      75141    75320     +179     
+ Partials     2432     2428       -4     
Flag Coverage Δ *Carryforward flag
differential 0.15% <0.00%> (?)
total 23.95% <ø> (-0.01%) ⬇️ Carriedforward from a7db560

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@SakodaShintaro SakodaShintaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the pull request.
Please fix the conflict 🙏

@a-maumau
Copy link
Contributor Author

@SakodaShintaro I fixed the conflict at 48f3b04 .

@@ -19,13 +19,14 @@
<buildtool_depend>ament_cmake</buildtool_depend>
<buildtool_depend>autoware_cmake</buildtool_depend>

<depend>autoware_map_height_fitter</depend>
<depend>autoware_map_height_fitter</depend>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

duplicated

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for my careless mistake. I fixed it at 52d6fa5 .

Copy link
Contributor

@SakodaShintaro SakodaShintaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have confirmed that logging_simulator, planning_simulator, driving_log_replayer and AWSIM work well.

I checked

  • Directory Name

    • Add autoware_ as a prefix to the directory name.
  • packages.xml

    • Add autoware_ to the name element.
  • CMakeLists.txt

    • Change the project name to autoware_***.
    • Add autoware:: to PLUGIN.
  • Header Files (.hpp)

    • Start #ifndef guards with AUTOWARE__.
    • Add autoware:: to namespace.
  • Source Files (.cpp)

    • Add autoware:: inside RCLCPP_COMPONENTS_REGISTER_NODE.
  • Launch Files

    • Add autoware_ before find-pkg-share.
    • Change node pkg="<pkgname>" to autoware_<pkgname>.
  • Include

    • Add autoware folder as necessary and update include statements accordingly.
    • Check for impacts on other packages.
  • Verification Points

    • Search find-pkg-share in autoware
    • Check README file (especially json schema)
    • Pay attention to complex cases like sensor_launch as seen in gnss_poser

@SakodaShintaro
Copy link
Contributor

@isamu-takagi Would you be able to review the changes of the system directory?

Copy link
Contributor

@isamu-takagi isamu-takagi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (ad_api_adaptors)

@hayato-m126 hayato-m126 merged commit 103e086 into autowarefoundation:main Aug 23, 2024
30 checks passed
kyoichi-sugahara pushed a commit to kyoichi-sugahara/autoware.universe that referenced this pull request Aug 27, 2024
…are (autowarefoundation#8421)

* add autoware_ prefix

Signed-off-by: a-maumau <[email protected]>

* style(pre-commit): autofix

* remove duplicated dependency

Signed-off-by: a-maumau <[email protected]>

---------

Signed-off-by: a-maumau <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: SakodaShintaro <[email protected]>
a-maumau added a commit to a-maumau/autoware.universe that referenced this pull request Sep 2, 2024
…are (autowarefoundation#8421)

* add autoware_ prefix

Signed-off-by: a-maumau <[email protected]>

* style(pre-commit): autofix

* remove duplicated dependency

Signed-off-by: a-maumau <[email protected]>

---------

Signed-off-by: a-maumau <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: SakodaShintaro <[email protected]>
ktro2828 pushed a commit to ktro2828/autoware.universe that referenced this pull request Sep 18, 2024
…are (autowarefoundation#8421)

* add autoware_ prefix

Signed-off-by: a-maumau <[email protected]>

* style(pre-commit): autofix

* remove duplicated dependency

Signed-off-by: a-maumau <[email protected]>

---------

Signed-off-by: a-maumau <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: SakodaShintaro <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:localization Vehicle's position determination in its environment. (auto-assigned) component:map Map creation, storage, and loading. (auto-assigned) component:system System design and integration. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) type:ci Continuous Integration (CI) processes and testing. (auto-assigned) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants