-
Notifications
You must be signed in to change notification settings - Fork 639
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(map_height_fitter)!: prefix package and namespace with autoware #8421
refactor(map_height_fitter)!: prefix package and namespace with autoware #8421
Conversation
Signed-off-by: a-maumau <[email protected]>
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8421 +/- ##
==========================================
- Coverage 23.96% 23.91% -0.05%
==========================================
Files 1382 1388 +6
Lines 102019 102185 +166
Branches 38886 38899 +13
==========================================
- Hits 24446 24437 -9
- Misses 75141 75320 +179
+ Partials 2432 2428 -4
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the pull request.
Please fix the conflict 🙏
@SakodaShintaro I fixed the conflict at 48f3b04 . |
@@ -19,13 +19,14 @@ | |||
<buildtool_depend>ament_cmake</buildtool_depend> | |||
<buildtool_depend>autoware_cmake</buildtool_depend> | |||
|
|||
<depend>autoware_map_height_fitter</depend> | |||
<depend>autoware_map_height_fitter</depend> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
duplicated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for my careless mistake. I fixed it at 52d6fa5 .
Signed-off-by: a-maumau <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have confirmed that logging_simulator, planning_simulator, driving_log_replayer and AWSIM work well.
I checked
-
Directory Name
- Add
autoware_
as a prefix to the directory name.
- Add
-
packages.xml
- Add
autoware_
to thename
element.
- Add
-
CMakeLists.txt
- Change the
project
name toautoware_***
. - Add
autoware::
toPLUGIN
.
- Change the
-
Header Files (.hpp)
- Start
#ifndef
guards withAUTOWARE__
. - Add
autoware::
tonamespace
.
- Start
-
Source Files (.cpp)
- Add
autoware::
insideRCLCPP_COMPONENTS_REGISTER_NODE
.
- Add
-
Launch Files
- Add
autoware_
beforefind-pkg-share
. - Change
node pkg="<pkgname>"
toautoware_<pkgname>
.
- Add
-
Include
- Add
autoware
folder as necessary and update include statements accordingly. - Check for impacts on other packages.
- Add
-
Verification Points
- Search
find-pkg-share
in autoware - Check README file (especially json schema)
- Pay attention to complex cases like
sensor_launch
as seen ingnss_poser
- Search
@isamu-takagi Would you be able to review the changes of the system directory? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (ad_api_adaptors)
…are (autowarefoundation#8421) * add autoware_ prefix Signed-off-by: a-maumau <[email protected]> * style(pre-commit): autofix * remove duplicated dependency Signed-off-by: a-maumau <[email protected]> --------- Signed-off-by: a-maumau <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: SakodaShintaro <[email protected]>
…are (autowarefoundation#8421) * add autoware_ prefix Signed-off-by: a-maumau <[email protected]> * style(pre-commit): autofix * remove duplicated dependency Signed-off-by: a-maumau <[email protected]> --------- Signed-off-by: a-maumau <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: SakodaShintaro <[email protected]>
…are (autowarefoundation#8421) * add autoware_ prefix Signed-off-by: a-maumau <[email protected]> * style(pre-commit): autofix * remove duplicated dependency Signed-off-by: a-maumau <[email protected]> --------- Signed-off-by: a-maumau <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: SakodaShintaro <[email protected]>
Description
This PR will add the
autoware_
prefix tomap_height_fitter
.This will affect driving_log_replayer
Related links
Parent Issue:
How was this PR tested?
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.