Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(autoware_image_projection_based_fusion): fix unusedFunction #8567

Merged

Conversation

kobayu858
Copy link
Contributor

Description

This is a fix based on cppcheck unusedFunction warnings.

perception/autoware_image_projection_based_fusion/src/utils/utils.cpp:51:0: style: The function 'convertCluster2FeatureObject' is never used. [unusedFunction]
void convertCluster2FeatureObject(
^

perception/autoware_image_projection_based_fusion/src/utils/utils.cpp:177:0: style: The function 'addShapeAndKinematic' is never used. [unusedFunction]
void addShapeAndKinematic(
^

perception/autoware_image_projection_based_fusion/src/utils/utils.cpp:264:0: style: The function 'getClosestPoint' is never used. [unusedFunction]
pcl::PointXYZ getClosestPoint(const pcl::PointCloud<pcl::PointXYZ> & cluster)
^

Related links

Parent Issue:

  • Link

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

Signed-off-by: kobayu858 <[email protected]>
@kobayu858 kobayu858 requested a review from veqcc August 22, 2024 02:57
@github-actions github-actions bot added component:perception Advanced sensor data processing and environment understanding. (auto-assigned) tag:require-cuda-build-and-test labels Aug 22, 2024
Copy link

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@kobayu858 kobayu858 added tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) and removed tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) labels Aug 22, 2024
Copy link

codecov bot commented Aug 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 23.96%. Comparing base (a7db560) to head (1d3406a).
Report is 24 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8567   +/-   ##
=======================================
  Coverage   23.96%   23.96%           
=======================================
  Files        1382     1383    +1     
  Lines      102019   101969   -50     
  Branches    38886    38858   -28     
=======================================
- Hits        24446    24439    -7     
+ Misses      75141    75102   -39     
+ Partials     2432     2428    -4     
Flag Coverage Δ *Carryforward flag
differential 2.99% <ø> (?)
total 23.96% <ø> (+<0.01%) ⬆️ Carriedforward from a7db560

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ktro2828
Copy link
Contributor

@badai-nguyen Could you confirm if it is OK to remove these functions you implemented?

Copy link
Contributor

@badai-nguyen badai-nguyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ktro2828 ktro2828 merged commit babadcf into autowarefoundation:main Aug 23, 2024
48 of 51 checks passed
kyoichi-sugahara pushed a commit to kyoichi-sugahara/autoware.universe that referenced this pull request Aug 27, 2024
a-maumau pushed a commit to a-maumau/autoware.universe that referenced this pull request Sep 2, 2024
ktro2828 pushed a commit to ktro2828/autoware.universe that referenced this pull request Sep 18, 2024
@kobayu858 kobayu858 deleted the fix/cppcheck_unusedFunction_per-6 branch October 1, 2024 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:perception Advanced sensor data processing and environment understanding. (auto-assigned) tag:require-cuda-build-and-test tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants