-
Notifications
You must be signed in to change notification settings - Fork 640
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(bpp): use common steering factor interface for same scene modules #8675
fix(bpp): use common steering factor interface for same scene modules #8675
Conversation
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
Signed-off-by: satoshi-ota <[email protected]>
fd505f2
to
51411f5
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8675 +/- ##
==========================================
- Coverage 24.16% 24.15% -0.02%
==========================================
Files 1401 1407 +6
Lines 102254 102297 +43
Branches 38750 38753 +3
==========================================
- Hits 24707 24705 -2
- Misses 74972 75017 +45
Partials 2575 2575
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
…autowarefoundation#8675) Signed-off-by: satoshi-ota <[email protected]> Signed-off-by: Batuhan Beytekin <[email protected]>
…autowarefoundation#8675) Signed-off-by: satoshi-ota <[email protected]> Signed-off-by: emuemuJP <[email protected]>
…autowarefoundation#8675) Signed-off-by: satoshi-ota <[email protected]>
fix(bpp): use common steering factor interface for same scene modules (autowarefoundation#8675)
…autowarefoundation#8675) Signed-off-by: satoshi-ota <[email protected]>
…autowarefoundation#8675) (#1505) Signed-off-by: satoshi-ota <[email protected]>
…autowarefoundation#8675) Signed-off-by: satoshi-ota <[email protected]>
Description
pass steering factor interface's pointer to scene module in order to redule frequency of constructing
SteeringFactorInterface
and callingcreate_publisher().
.Related links
Parent Issue:
How was this PR tested?
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.