Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(bpp): use common steering factor interface for same scene modules #8675

Merged
merged 1 commit into from
Sep 2, 2024
Merged

fix(bpp): use common steering factor interface for same scene modules #8675

merged 1 commit into from
Sep 2, 2024

Conversation

satoshi-ota
Copy link
Contributor

@satoshi-ota satoshi-ota commented Aug 29, 2024 •
edited
Loading

Description

pass steering factor interface's pointer to scene module in order to redule frequency of constructing SteeringFactorInterface and calling create_publisher()..

Related links

Parent Issue:

  • Link

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Aug 29, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 29, 2024 •
edited
Loading

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@satoshi-ota satoshi-ota force-pushed the fix/use-common-steering-factor branch from fd505f2 to 51411f5 Compare August 31, 2024 04:08
@satoshi-ota satoshi-ota marked this pull request as ready for review September 1, 2024 23:03
@maxime-clem maxime-clem added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Sep 2, 2024
@codecov Codecov
Copy link

codecov bot commented Sep 2, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 55.55556% with 8 lines in your changes missing coverage. Please review.

Project coverage is 24.15%. Comparing base (3e4a945) to head (51411f5).
Report is 13 commits behind head on main.

Files with missing lines Patch % Lines
...path_dynamic_obstacle_avoidance_module/manager.hpp 0.00% 1 Missing ⚠️
...th_dynamic_obstacle_avoidance_module/src/scene.cpp 0.00% 1 Missing ⚠️
...ware/behavior_path_goal_planner_module/manager.hpp 0.00% 1 Missing ⚠️
...th_goal_planner_module/src/goal_planner_module.cpp 0.00% 1 Missing ⚠️
.../behavior_path_sampling_planner_module/manager.hpp 0.00% 1 Missing ⚠️
...ing_planner_module/src/sampling_planner_module.cpp 0.00% 1 Missing ⚠️
...are/behavior_path_start_planner_module/manager.hpp 0.00% 1 Missing ⚠️
..._start_planner_module/src/start_planner_module.cpp 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #8675      +/-   ##
==========================================
- Coverage   24.16%   24.15%   -0.02%     
==========================================
  Files        1401     1407       +6     
  Lines      102254   102297      +43     
  Branches    38750    38753       +3     
==========================================
- Hits        24707    24705       -2     
- Misses      74972    75017      +45     
  Partials     2575     2575
Flag Coverage Δ *Carryforward flag
differential 15.11% <55.55%> (?)
total 24.15% <ø> (-0.01%) ⬇️ Carriedforward from 3e4a945

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

kyoichi-sugahara
kyoichi-sugahara approved these changes Sep 2, 2024
View reviewed changes
Copy link
Contributor

@kyoichi-sugahara kyoichi-sugahara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@satoshi-ota satoshi-ota merged commit 564de29 into autowarefoundation:main Sep 2, 2024
43 of 45 checks passed
@satoshi-ota satoshi-ota deleted the fix/use-common-steering-factor branch September 2, 2024 10:08
batuhanbeytekin pushed a commit to batuhanbeytekin/autoware.universe that referenced this pull request Sep 2, 2024
@satoshi-ota @batuhanbeytekin
fix(bpp): use common steering factor interface for same scene modules (…
c34983e 
…autowarefoundation#8675)

Signed-off-by: satoshi-ota <[email protected]>
Signed-off-by: Batuhan Beytekin <[email protected]>
emuemuJP pushed a commit to arayabrain/autoware.universe.origin that referenced this pull request Sep 2, 2024
@satoshi-ota @emuemuJP
fix(bpp): use common steering factor interface for same scene modules (…
cebf128 
…autowarefoundation#8675)

Signed-off-by: satoshi-ota <[email protected]>
Signed-off-by: emuemuJP <[email protected]>
satoshi-ota added a commit to tier4/autoware.universe that referenced this pull request Sep 3, 2024
@satoshi-ota
fix(bpp): use common steering factor interface for same scene modules (…
a82c0ef 
…autowarefoundation#8675)

Signed-off-by: satoshi-ota <[email protected]>
@satoshi-ota satoshi-ota mentioned this pull request Sep 3, 2024
Merged
satoshi-ota added a commit to tier4/autoware.universe that referenced this pull request Sep 3, 2024
@satoshi-ota
Merge pull request #1503 from tier4/hotfix/v0.29.0/cherry-pick-bpp
42c9a11 
fix(bpp): use common steering factor interface for same scene modules (autowarefoundation#8675)
satoshi-ota added a commit to tier4/autoware.universe that referenced this pull request Sep 3, 2024
@satoshi-ota
fix(bpp): use common steering factor interface for same scene modules (…
6a55e0c 
…autowarefoundation#8675)

Signed-off-by: satoshi-ota <[email protected]>
@satoshi-ota satoshi-ota mentioned this pull request Sep 3, 2024
Merged
kotaro-hihara pushed a commit to tier4/autoware.universe that referenced this pull request Sep 3, 2024
@satoshi-ota
fix(bpp): use common steering factor interface for same scene modules (…
d2142b9 
…autowarefoundation#8675) (#1505)

Signed-off-by: satoshi-ota <[email protected]>
ktro2828 pushed a commit to ktro2828/autoware.universe that referenced this pull request Sep 18, 2024
@satoshi-ota @ktro2828
fix(bpp): use common steering factor interface for same scene modules (…
cc24524 
…autowarefoundation#8675)

Signed-off-by: satoshi-ota <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kyoichi-sugahara kyoichi-sugahara kyoichi-sugahara approved these changes

@maxime-clem maxime-clem maxime-clem approved these changes

@rej55 rej55 Awaiting requested review from rej55 rej55 is a code owner

@go-sakayori go-sakayori Awaiting requested review from go-sakayori go-sakayori is a code owner

@shmpwk shmpwk Awaiting requested review from shmpwk shmpwk is a code owner

@TakaHoribe TakaHoribe Awaiting requested review from TakaHoribe TakaHoribe is a code owner

@TomohitoAndo TomohitoAndo Awaiting requested review from TomohitoAndo TomohitoAndo is a code owner

@tkimura4 tkimura4 Awaiting requested review from tkimura4 tkimura4 is a code owner

@zulfaqar-azmi-t4 zulfaqar-azmi-t4 Awaiting requested review from zulfaqar-azmi-t4 zulfaqar-azmi-t4 is a code owner

@danielsanchezaran danielsanchezaran Awaiting requested review from danielsanchezaran danielsanchezaran is a code owner

@kosuke55 kosuke55 Awaiting requested review from kosuke55 kosuke55 is a code owner

@soblin soblin Awaiting requested review from soblin soblin is a code owner

@takayuki5168 takayuki5168 Awaiting requested review from takayuki5168 takayuki5168 is a code owner

@mkquda mkquda Awaiting requested review from mkquda mkquda is a code owner

@yuki-takagi-66 yuki-takagi-66 Awaiting requested review from yuki-takagi-66 yuki-takagi-66 is a code owner

Assignees
No one assigned
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@satoshi-ota @kyoichi-sugahara @maxime-clem