fix(lane_change): set initail rtc state properly #8902
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Go Sakayori <[email protected]>
github-actions
bot
added
the
component:planning
|
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
go-sakayori
requested review from
mkquda,
rej55,
kosuke55,
maxime-clem,
satoshi-ota,
shmpwk,
TomohitoAndo,
tkimura4 and
zulfaqar-azmi-t4
as code owners
zulfaqar-azmi-t4
approved these changes
Sep 19, 2024
zulfaqar-azmi-t4
added
the
tag:run-build-and-test-differential
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8902 +/- ##
==========================================
- Coverage 28.00% 27.99% -0.01%
==========================================
Files 1319 1320 +1
Lines 98699 98730 +31
Branches 39787 39789 +2
==========================================
+ Hits 27641 27643 +2
- Misses 70989 71017 +28
- Partials 69 70 +1
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
go-sakayori
added a commit
to tier4/autoware.universe
that referenced
this pull request
Sep 19, 2024
…8902) set initail rtc state properly Signed-off-by: Go Sakayori <[email protected]>
rej55
added a commit
to tier4/autoware.universe
that referenced
this pull request
Sep 20, 2024
fix(lane_change): set initial rtc state properly (autowarefoundation#8902)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The following WARNING appears when the lane change module `plan()' function is called at it's first time.
This PR solves the warnings by checking whether the uuid is registered or not.
If the uuid is not registered the cooperateStatus state is set to WAITING_FOR_EXECUTION and the force activation is not checked.
Related links
How was this PR tested?
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.