Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(costmap_generator): manual blurring and fill polygons without OpenCV #9160

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

maxime-clem
Copy link
Contributor

@maxime-clem maxime-clem commented Oct 25, 2024

Description

Decrease runtime from 20ms (with 30ms spikes) to 8ms (with 10ms spikes) in my local tests.

Related links

Private Links:

How was this PR tested?

Psim

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Oct 25, 2024
Copy link

github-actions bot commented Oct 25, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@maxime-clem maxime-clem added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Oct 25, 2024
Copy link

codecov bot commented Oct 25, 2024

Codecov Report

Attention: Patch coverage is 40.42553% with 28 lines in your changes missing coverage. Please review.

Project coverage is 28.61%. Comparing base (35ecc19) to head (e8f2cd6).

Files with missing lines Patch % Lines
...oware_costmap_generator/costmap_generator_node.cpp 0.00% 12 Missing ⚠️
...es/autoware_costmap_generator/object_map_utils.cpp 0.00% 8 Missing ⚠️
.../autoware_costmap_generator/objects_to_costmap.cpp 70.37% 4 Missing and 4 partials ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #9160   +/-   ##
=======================================
  Coverage   28.60%   28.61%           
=======================================
  Files        1308     1308           
  Lines      101245   101247    +2     
  Branches    39354    39354           
=======================================
+ Hits        28957    28967   +10     
+ Misses      69351    69340   -11     
- Partials     2937     2940    +3     
Flag Coverage Δ *Carryforward flag
differential 10.47% <40.42%> (?)
total 28.60% <ø> (+<0.01%) ⬆️ Carriedforward from 35ecc19

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant