Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(lane_change): revert "remove std::optional from lanes polygon" #9272

Merged

Conversation

youtalk
Copy link
Member

@youtalk youtalk commented Nov 8, 2024

Reverts #9267

It seems that due to the changes in #9267, the autoware_behavior_path_lane_change_module is causing build errors, which has broken autoware.universe.
@zulfaqar-azmi-t4 Please address this issue. In the meantime, I have created this revert PR.

https://github.com/autowarefoundation/autoware.universe/actions/runs/11739742637/job/32704854017#step:13:30725

/__w/autoware.universe/autoware.universe/planning/behavior_path_planner/autoware_behavior_path_lane_change_module/src/utils/utils.cpp: In lambda function:
/__w/autoware.universe/autoware.universe/planning/behavior_path_planner/autoware_behavior_path_lane_change_module/src/utils/utils.cpp:1315:88: error: 'class lanelet::BasicPolygon2d' has no member named 'value'
 1315 |     return !boost::geometry::disjoint(path, common_data_ptr->lanes_polygon_ptr->target.value());
      |                                                                                        ^~~~~
/__w/autoware.universe/autoware.universe/planning/behavior_path_planner/autoware_behavior_path_lane_change_module/src/utils/utils.cpp: In lambda function:
/__w/autoware.universe/autoware.universe/planning/behavior_path_planner/autoware_behavior_path_lane_change_module/src/utils/utils.cpp:1322:79: error: 'class lanelet::BasicPolygon2d' has no member named 'value'
 1322 |           object.initial_polygon, common_data_ptr->lanes_polygon_ptr->current.value())) {
      |                                                                               ^~~~~

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Nov 8, 2024
Copy link

github-actions bot commented Nov 8, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@youtalk youtalk added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Nov 8, 2024
@youtalk youtalk enabled auto-merge (squash) November 8, 2024 12:58
@youtalk youtalk merged commit 1ea45e6 into main Nov 8, 2024
35 of 36 checks passed
@youtalk youtalk deleted the revert-9267-refactor-remove-std-optional-from-lanes-polygon branch November 8, 2024 13:14
Copy link

codecov bot commented Nov 8, 2024

Codecov Report

Attention: Patch coverage is 43.75000% with 9 lines in your changes missing coverage. Please review.

Project coverage is 29.22%. Comparing base (b6118ac) to head (e6664bd).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
...are_behavior_path_lane_change_module/src/scene.cpp 0.00% 5 Missing ⚠️
...havior_path_lane_change_module/src/utils/utils.cpp 63.63% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9272      +/-   ##
==========================================
- Coverage   29.23%   29.22%   -0.01%     
==========================================
  Files        1336     1337       +1     
  Lines      102981   103006      +25     
  Branches    39955    39951       -4     
==========================================
+ Hits        30105    30107       +2     
- Misses      69791    69815      +24     
+ Partials     3085     3084       -1     
Flag Coverage Δ *Carryforward flag
differential 20.08% <43.75%> (?)
total 29.23% <43.75%> (+<0.01%) ⬆️ Carriedforward from b6118ac

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants