CodeScene PR Check
β Code Health Quality Gates: FAILED
-
Declining Code Health: 4 findings(s) π©
-
Affected Hotspots: 1 files(s) π₯
Details
π© Declining Code Health (highest to lowest):
- Complex Conditional utils.cpp: isNeverAvoidanceTarget π₯
- Complex Method utils.cpp: isNeverAvoidanceTarget π₯
- Large Method debug.cpp: createDebugMarkerArray
- Bumpy Road Ahead utils.cpp: isNeverAvoidanceTarget π₯
Annotations
Check warning on line 581 in planning/behavior_path_avoidance_module/src/debug.cpp
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
β Getting worse: Large Method
createDebugMarkerArray increases from 112 to 113 lines of code, threshold = 70. Large functions with many lines of code are generally harder to understand and lower the code health. Avoid adding more lines to this function.
Check notice on line 1 in planning/behavior_path_avoidance_module/src/utils.cpp
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
βΉ Getting worse: Lines of Code in a Single File
The lines of code increases from 1750 to 1788, improve code health by reducing it to 1000. The number of Lines of Code in a single file. More Lines of Code lowers the code health.
Check warning on line 618 in planning/behavior_path_avoidance_module/src/utils.cpp
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
β Getting worse: Complex Method
isNeverAvoidanceTarget increases in cyclomatic complexity from 11 to 25, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
Check warning on line 610 in planning/behavior_path_avoidance_module/src/utils.cpp
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
β New issue: Complex Conditional
isNeverAvoidanceTarget has 4 complex conditionals with 8 branches, threshold = 2. A complex conditional is an expression inside a branch (e.g. if, for, while) which consists of multiple, logical operators such as AND/OR. The more logical operators in an expression, the more severe the code smell.
Check warning on line 618 in planning/behavior_path_avoidance_module/src/utils.cpp
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
β Getting worse: Bumpy Road Ahead
isNeverAvoidanceTarget increases from 3 to 5 logical blocks with deeply nested code, threshold is one single block per function. The Bumpy Road code smell is a function that contains multiple chunks of nested conditional logic. The deeper the nesting and the more bumps, the lower the code health.
Check notice on line 1 in planning/behavior_path_avoidance_module/src/utils.cpp
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
βΉ Getting worse: Overall Code Complexity
The mean cyclomatic complexity increases from 4.81 to 5.00, threshold = 4. This file has many conditional statements (e.g. if, for, while) across its implementation, leading to lower code health. Avoid adding more conditionals.