Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to lanelet2_map_loader for local coordinates #3427

Closed
7 tasks done
isamu-takagi opened this issue Apr 13, 2023 · 5 comments · Fixed by autowarefoundation/autoware.universe#5866
Closed
7 tasks done
Assignees
Labels
component:interfaces Communication protocols, interfaces and messages. component:map Map creation, storage, and loading. type:new-feature New functionalities or additions, feature requests.

Comments

@isamu-takagi
Copy link
Contributor

isamu-takagi commented Apr 13, 2023

Checklist

  • I've read the contribution guidelines.
  • I've searched other issues and no duplicate issues were found.
  • I've agreed with the maintainers that I can plan this task.

Description

I'm developing API that provides the global vehicle position (latitude and longitude). For that, I tried to convert from map position to global position, but the autoware osm parser in the lanelet2_extension package overwrites position if local_x or local_y is specified in the Lanelet2 map. This works regardless of the projection type settings in the map loader, the transformation may not match the map projection type. So add an explicit option to the map loader to use local coordinates.

Purpose

To support reverse projection of coordinates in different nodes

Possible approaches

  • Add a local projection type option to the lanelet2 map loader and use local coordinates only with this option.
  • Add a dummy projector that does nothing because it is overwritten if local projection type is used (optional).

Definition of done

@tkhmy
Copy link

tkhmy commented Apr 21, 2023

I removed the local parser for lanelet_extension
autowarefoundation/autoware_common#174

the local parser will be in map_loader
autowarefoundation/autoware.universe#3492

@xmfcx xmfcx added type:new-feature New functionalities or additions, feature requests. component:map Map creation, storage, and loading. component:interfaces Communication protocols, interfaces and messages. and removed Type: improvement labels Nov 14, 2023
@xmfcx
Copy link
Contributor

xmfcx commented Nov 16, 2023

@isamu-takagi -san,

The task: Add dummy projector to lanelet2_extension

  • Is this task important, will it be implemented?

@isamu-takagi
Copy link
Contributor Author

The task: Add dummy projector to lanelet2_extension

This task is not important. Currently, if a local type is used, it is overwritten with local coordinates after being projected with MGRS, so there is a bit of processing waste.

Also, there may be cases where only some positions are overwritten with local coordinates. In this case, it is better to be able to specify a sub-projection type when using local projections.

@isamu-takagi
Copy link
Contributor Author

Also, there may be cases where only some positions are overwritten with local coordinates. In this case, it is better to be able to specify a sub-projection type when using local projections.

Changed to use dummy projector. I will consider adding the above cases if necessary.
autowarefoundation/autoware.universe#5866

@xmfcx
Copy link
Contributor

xmfcx commented Dec 21, 2023

Thank you @isamu-takagi -san!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:interfaces Communication protocols, interfaces and messages. component:map Map creation, storage, and loading. type:new-feature New functionalities or additions, feature requests.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants