Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create api for vehicle status #3232

Closed
3 tasks done
tkhmy opened this issue Nov 28, 2022 · 5 comments · Fixed by autowarefoundation/autoware-documentation#415
Closed
3 tasks done

Create api for vehicle status #3232

tkhmy opened this issue Nov 28, 2022 · 5 comments · Fixed by autowarefoundation/autoware-documentation#415
Assignees
Labels
type:new-feature New functionalities or additions, feature requests.

Comments

@tkhmy
Copy link

tkhmy commented Nov 28, 2022

Checklist

  • I've read the contribution guidelines.
  • I've searched other issues and no duplicate issues were found.
  • I've agreed with the maintainers that I can plan this task.

Description

Hi, currently autoware do not have any api that can monitor the vehicle status, if an user or application want to get the information, they will need to get from different topic.
I suggest to create an api that combine the vehicle status and output into 1 topic.

Purpose

Hi, I'm thinking to port the vehicle status to autoware.
https://github.com/tier4/tier4_ad_api_adaptor/tree/tier4/universe/awapi_awiv_adapter#awapivehiclegetstatus

Here will the layout

  • position
  • geo_point
  • velocity
    - target_velocity
  • acceleration
    - target_acceleration
  • gear
  • turn_indicators
  • hazard_lights
  • door
  • energy

Possible approaches

The documentation PR
autowarefoundation/autoware-documentation#312

https://autowarefoundation.github.io/autoware-documentation/pr-312/design/autoware-interfaces/ad-api/list/api/vehicle/

Definition of done

An api that combine the vehicle status and output to the user and application is created

@tkhmy tkhmy self-assigned this Nov 28, 2022
@BonoloAWF BonoloAWF added the type:new-feature New functionalities or additions, feature requests. label Nov 28, 2022
@isamu-takagi isamu-takagi transferred this issue from autowarefoundation/autoware.universe Jan 26, 2023
@isamu-takagi isamu-takagi self-assigned this Jan 26, 2023
@isamu-takagi
Copy link
Contributor

For target_velocity and target_acceleration, It might be better to separate these as vehicle command message.
For geo_point, this cannot be provided if the map only has local coordinates.

@tkhmy
Copy link
Author

tkhmy commented Jan 31, 2023

For target_velocity and target_acceleration, It might be better to separate these as vehicle command message. For geo_point, this cannot be provided if the map only has local coordinates.

Sorry for late reply, I miss the message.
I agree that we should move the target_velocity and target_acceleration to vehicle_command.
We should just put in the current vehicle status data

For the geo_point I think we might able to convert from MGRS to the global longitude and latitude

@tkhmy
Copy link
Author

tkhmy commented Feb 1, 2023

@isamu-takagi
Copy link
Contributor

For the geo_point I think we might able to convert from MGRS to the global longitude and latitude

According to the lanelet2_extension documentation, Autoware works in a local coordinate system independent of MGRS by setting local_x and local_y.

@isamu-takagi
Copy link
Contributor

I forgot the API to control doors. I have three suggestions.

  1. array command
message:
  - NONE
  - CLOSE
  - CLOSE
  - NONE
  1. index command
message:
  - { index: 1, command: CLOSE }
  - { index: 2, command: CLOSE }
  1. role command
message:
  - { role: GET_ON, command: CLOSE }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:new-feature New functionalities or additions, feature requests.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants