Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the same tag for multiple cpu architectures in docker images #5174

Closed
3 tasks done
xmfcx opened this issue Sep 5, 2024 · 6 comments
Closed
3 tasks done

Use the same tag for multiple cpu architectures in docker images #5174

xmfcx opened this issue Sep 5, 2024 · 6 comments
Assignees
Labels
component:openadkit Issues or Features related to Open AD Kit type:containers Docker containers, containerization of components, or container orchestration.

Comments

@xmfcx
Copy link
Contributor

xmfcx commented Sep 5, 2024

Checklist

  • I've read the contribution guidelines.
  • I've searched other issues and no duplicate issues were found.
  • I've agreed with the maintainers that I can plan this task.

Description

image

Right now we have different tags for arm64 and amd64 images.

This is redundant since docker supports multiple cpu arch's in same tag.

Example:
image

Purpose

Simplify the docker image tags by making use of modern docker features.

Possible approaches

https://www.docker.com/blog/multi-arch-build-and-images-the-simple-way/

Definition of done

Image tags don't have arm64 or amd64 keywords in them.

@xmfcx xmfcx added the type:containers Docker containers, containerization of components, or container orchestration. label Sep 5, 2024
@xmfcx xmfcx changed the title Use same tag for multiple cpu architectures in docker images Use the same tag for multiple cpu architectures in docker images Sep 5, 2024
@xmfcx
Copy link
Contributor Author

xmfcx commented Sep 5, 2024

However, my question is: why are we generating architecture-specific tags initially and then merging them later? Wouldn't it be cleaner and more efficient to push a single tag directly, without separating them at the start? This could help in keeping the package repository more organized.

@youtalk
Copy link
Member

youtalk commented Sep 5, 2024

I don't know how to do it properly because the CI runners are different from machines and architectures so that I think the manifest could be also different.
I hope @oguzkaganozt knows more than me.

@youtalk
Copy link
Member

youtalk commented Sep 5, 2024

This is not my emergent issue.
I'm waiting for your contribution not only by discussion but by PR.
Thanks.

@oguzkaganozt oguzkaganozt self-assigned this Sep 6, 2024
@oguzkaganozt oguzkaganozt added the component:openadkit Issues or Features related to Open AD Kit label Sep 6, 2024
@oguzkaganozt
Copy link
Contributor

I will investigate try to find out more straight-forward solution to this.

@oguzkaganozt
Copy link
Contributor

This should be resolved with #5256

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:openadkit Issues or Features related to Open AD Kit type:containers Docker containers, containerization of components, or container orchestration.
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants