Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(test-composite-actions): use autoware:latest-universe-devel #319

Conversation

sasakisasaki
Copy link
Contributor

@sasakisasaki sasakisasaki commented Sep 5, 2024

Description

Fix not to use outdated image in the workflow.

Related links

Not provided.

Tests performed

By this workflow

Notes for reviewers

Before this fix, the workflow test-get-self-packages-and-get-modified-packages was failing with following error.

  /usr/bin/docker --config /home/runner/work/_temp/.docker_5d3b7430-f2fa-4f8f-9a5c-a5d59f5f0360 login ghcr.io -u sasakisasaki --password-stdin
  /usr/bin/docker --config /home/runner/work/_temp/.docker_5d3b7430-f2fa-4f8f-9a5c-a5d59f5f0360 pull ghcr.io/autowarefoundation/autoware-universe:humble-latest
  Error response from daemon: denied
  Warning: Docker pull failed with exit code 1, back off 5.707 seconds before retry.
  /usr/bin/docker --config /home/runner/work/_temp/.docker_5d3b7430-f2fa-4f8f-9a5c-a5d59f5f0360 pull ghcr.io/autowarefoundation/autoware-universe:humble-latest
  Error response from daemon: denied
  Warning: Docker pull failed with exit code 1, back off 1.836 seconds before retry.
  /usr/bin/docker --config /home/runner/work/_temp/.docker_5d3b7430-f2fa-4f8f-9a5c-a5d59f5f0360 pull ghcr.io/autowarefoundation/autoware-universe:humble-latest
  Error response from daemon: denied
  Error: Docker pull failed with exit code 1

Interface changes

No interface change in this PR

ROS Topic Changes

No ROS topic change in this PR

ROS Parameter Changes

No ROS parameter change in this PR

Effects on system behavior

The failing workflow will be functional.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

  * As the previous one is outdated by 6 months
  * Before this fix, the workflow was failing with following error:
```
Error response from daemon: Head "https://ghcr.io/v2/autowarefoundation/autoware-universe/manifests/humble-latest": unauthorized
```

Signed-off-by: Junya Sasaki <[email protected]>
@sasakisasaki sasakisasaki marked this pull request as ready for review September 5, 2024 09:38
@xmfcx
Copy link
Contributor

xmfcx commented Sep 5, 2024

  /usr/bin/docker --config /home/runner/work/_temp/.docker_2d3e4b84-a87e-4e1f-a09f-7a130024fc9e login ghcr.io -u sasakisasaki --password-stdin
  /usr/bin/docker --config /home/runner/work/_temp/.docker_2d3e4b84-a87e-4e1f-a09f-7a130024fc9e pull ghcr.io/autowarefoundation/autoware:latest-universe-devel
  Error response from daemon: manifest unknown
  Warning: Docker pull failed with exit code 1, back off 7.088 seconds before retry.
  /usr/bin/docker --config /home/runner/work/_temp/.docker_2d3e4b84-a87e-4e1f-a09f-7a130024fc9e pull ghcr.io/autowarefoundation/autoware:latest-universe-devel
  Error response from daemon: manifest unknown
  Warning: Docker pull failed with exit code 1, back off 6.361 seconds before retry.
  /usr/bin/docker --config /home/runner/work/_temp/.docker_2d3e4b84-a87e-4e1f-a09f-7a130024fc9e pull ghcr.io/autowarefoundation/autoware:latest-universe-devel
  Error response from daemon: manifest unknown
  Error: Docker pull failed with exit code 1

@sasakisasaki
Copy link
Contributor Author

@xmfcx Thank you for a quick check, let me investigate, ... .

@sasakisasaki
Copy link
Contributor Author

@xmfcx
Copy link
Contributor

xmfcx commented Sep 5, 2024

@youtalk -san, we shouldn't need arm64 or amd64 keywords in the tags.

https://hub.docker.com/_/ros/tags

image

I will create an issue for this.

Done:

@xmfcx xmfcx merged commit de662d6 into autowarefoundation:main Sep 5, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants