Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): add separate .clang-tidy-ci file #4918

Merged
merged 4 commits into from
Jun 26, 2024

Conversation

veqcc
Copy link
Contributor

@veqcc veqcc commented Jun 26, 2024

Description

This is the first step to achive the proposal: https://github.com/orgs/autowarefoundation/discussions/4876 .

I have made the following changes:

  • make a new clang-tidy configuration file clang-tidy-ci for CI workflow
    • It checks the same warnings as it is, while severity HIGH and MEDIUM warnings are treated as errors, which will prevent each PR from being merged when it contains HIGH and MEDIUM warnings
  • delete the outdated feature AnalyzeTemporaryDtors: false
  • delete the default setting FormatStyle: none

Checks and CheckOptions are exactly the same as original.

After this PR is merged, then each PR in autoware.universe would pass clang-tidy-differential workflow, unless it invokes new warnings.

Tests performed

The clang-tidy warnings are obtained in tier4 universe v0.29.0: https://github.com/tier4/autoware.universe/tree/v0.29.0 .

Effects on system behavior

Not applicable.

Interface changes

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@veqcc veqcc self-assigned this Jun 26, 2024
@veqcc veqcc requested review from mitsudome-r and removed request for mitsudome-r June 26, 2024 01:24
@veqcc veqcc added the type:ci Continuous Integration (CI) processes and testing. label Jun 26, 2024
@mojomex
Copy link
Contributor

mojomex commented Jun 26, 2024

@veqcc
Hi!
I just commented on the discussion page because this PR would break my in-IDE code analysis/style checks. Please review when you have time 🙏

Copy link
Contributor

@xmfcx xmfcx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.clang-tidy Outdated Show resolved Hide resolved
@mitsudome-r
Copy link
Member

Is the plan to add the same file in autoware.universe as well once this is merged?

@xmfcx
Copy link
Contributor

xmfcx commented Jun 26, 2024

@mitsudome-r

https://github.com/autowarefoundation/autoware.universe/blob/23d857d1c072525422a49f6ac6ec9364235bc55f/.github/workflows/clang-tidy-differential.yaml#L51

they are using this file here. No need to change in universe.

@xmfcx xmfcx changed the title chore(ci): reduce clang-tidy warnings to the minimum chore(ci): add separate .clang-tidy-ci file Jun 26, 2024
@xmfcx xmfcx merged commit ada7b8c into autowarefoundation:main Jun 26, 2024
16 of 17 checks passed
@veqcc veqcc deleted the update_clang_tidy branch June 26, 2024 14:43
pravinkmr26 pushed a commit to pravinkmr26/autoware that referenced this pull request Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:ci Continuous Integration (CI) processes and testing.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants