chore(tools.repos): add auto-msgs repository to tools.repos #5197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: temkei.kem <[email protected]>
Signed-off-by: temkei.kem <[email protected]>
xmfcx
reviewed
Sep 9, 2024
Co-authored-by: M. Fatih Cırıt <[email protected]>
xmfcx
reviewed
Sep 9, 2024
| @@ -3,3 +3,7 @@ repositories: | |||
| type: git | |||
| url: https://github.com/autowarefoundation/autoware_tools.git | |||
| version: main | |||
| tools/external/autoware_auto_msgs: | |||
There was a problem hiding this comment.
Suggested change
| tools/external/autoware_auto_msgs: | |
| tools/external/autoware_auto_msgs: |
But we cannot do this either. The tools folder is occupied by the autoware_tools.git above.
It be a repo in repo situation and git tracking will break.
This should go somewhere else.
Maybe new structure as:
https://github.com/autowarefoundation/autoware_tools.git goes to tools/autoware_tools:
https://github.com/tier4/autoware_auto_msgs.git goes to tools/external/autoware_auto_msgs:
But still, do we really need to add this old package back in autoware?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add auto-msgs repository to
tools.repos, because the tools need it to load and analyze the old rosbags with old messages.Tests performed
Not applicable.
Effects on system behavior
Not applicable.
Interface changes
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.