-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(docker): add vehicle-system container #5257
Conversation
@youtalk please review |
c625bfd
to
9f510ff
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't determine the optimal granularity for separating the other universe
containers.
@mitsudome-r @xmfcx What do you think?
4256ce6
to
0835ff0
Compare
@youtalk @mitsudome-r @xmfcx IMHO, in order to make it possible to develop/deploy autoware within a fully modularized environment we should have containers for each autoware/universe directory that being:
And optional containers for:
|
@youtalk Updated and started a new workflow run https://github.com/autowarefoundation/autoware/actions/runs/10962267642 for generating images |
71a0803
to
b17fbd2
Compare
I think it's reasonable to have vehicle as a separate container. (This module could be modified/replaced by the users depending on their vehicle hardware) Regarding the system component, we might need to have some discussions. It might be suitable to be merged with planning/control as we don't have a completely fixed interface defined between the system component and the rest of Autoware. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update the Dockerfile.svg by using https://github.com/patrickhoefler/dockerfilegraph.
Signed-off-by: Oguz Ozturk <[email protected]>
Signed-off-by: Oguz Ozturk <[email protected]>
Signed-off-by: Oguz Ozturk <[email protected]>
Signed-off-by: Oguz Ozturk <[email protected]>
Signed-off-by: Oguz Ozturk <[email protected]>
Signed-off-by: Oguz Ozturk <[email protected]>
5e91215
to
f5c6f66
Compare
Description
Add
vehicle-system module
container according to the proposalTests performed
https://github.com/autowarefoundation/autoware/actions/runs/10962267642
Effects on system behavior
Not applicable.
Interface changes
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.