feat(autoware_adapi_v1_msgs): add vehicle info msgs #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Takagi, Isamu <[email protected]>
Signed-off-by: Takagi, Isamu <[email protected]>
isamu-takagi
changed the title
xmfcx
reviewed
Mar 16, 2023
Signed-off-by: Takagi, Isamu <[email protected]>
isamu-takagi
requested review from
tkhmy,
yukkysaito,
kenji-miyake and
mitsudome-r
yukkysaito
reviewed
Mar 27, 2023
Signed-off-by: Takagi, Isamu <[email protected]>
yukkysaito
approved these changes
Apr 5, 2023
|
@mitsudome-r @xmfcx Could you please review this PR? |
|
Thanks for the efforts, it seems OK to me. Could you also add some documentation for how these messages can be used and why they exist? If you'd like to create another PR for this, that's OK too. |
xmfcx
approved these changes
Apr 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related links
autowarefoundation/autoware-documentation#317
Tests performed
Notes for reviewers
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.