Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(autoware_adapi_v1_msgs): add route following check option #61

Conversation

isamu-takagi
Copy link
Collaborator

@isamu-takagi isamu-takagi commented Sep 4, 2024

Description

Add option for route change API. See autowarefoundation/autoware-documentation#602 for details.

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Interface changes

None (only add message field)

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@isamu-takagi isamu-takagi self-assigned this Sep 4, 2024
@isamu-takagi isamu-takagi changed the title Feat/add route following check option feat(autoware_adapi_v1_msgs): add route following check option Sep 4, 2024
Copy link
Member

@youtalk youtalk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sasakisasaki
Copy link

@isamu-takagi Thank you! Let me ask a question, does the allow_while_using_route have a default value, or all functions which are using this message can handle the merged message?

@isamu-takagi
Copy link
Collaborator Author

@sasakisasaki The default value is false.

Copy link

@sasakisasaki sasakisasaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@isamu-takagi Thank you for the answer! Then LGTM 👍

@isamu-takagi isamu-takagi enabled auto-merge (squash) October 22, 2024 07:58
@isamu-takagi isamu-takagi merged commit 9a296e7 into autowarefoundation:main Oct 22, 2024
14 of 16 checks passed
@isamu-takagi isamu-takagi mentioned this pull request Oct 22, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants