This repository has been archived by the owner on Jul 1, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since it's true that
autoware_cmake
depends onros_environment
, I guess we should write the dependency in some way.Seeing the example of
gtest_vendor
inament_cmake_gtest
, isbuildtool_export_depend
the correct tag?https://github.com/ament/ament_cmake/blob/c5489e8c22489625a804618a160649953d21dec8/ament_cmake_gtest/package.xml#L19
https://github.com/ament/ament_cmake/blob/c5489e8c22489625a804618a160649953d21dec8/ament_cmake_gtest/ament_cmake_gtest-extras.cmake#L41
Is that wrong, too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, #144 did it. Thank you @jspricke!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kenji-miyake
autoware_cmake
does not depend onros_environment
, it depends on theROS_DISTRO
environment variable, but not that package. So unfortunately, #144 is still incorrect.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@esteve Thank you. Hmm, let me confirm a little more.
There are two facts:
ros_environment
provides the environment variablesROS_VERSION
andROS_DISTRO
.ROS_VERSION
(one of theros_environment
's env), depend onros_environment
.https://github.com/tier4/osqp_vendor/blob/1ea3682dacc08bd05d301098b202e74bd6416251/package.xml#L19
What's the difference between those packages and
autoware_cmake
?