Skip to content
This repository has been archived by the owner on Jul 1, 2024. It is now read-only.

feat(lanelet2_extension_python): add python interface/bindings for autoware map and lanelet2_extension package #221

Merged
merged 9 commits into from
Jan 18, 2024

Conversation

soblin
Copy link
Contributor

@soblin soblin commented Dec 18, 2023

Description

I added lanelet2_extension_python package. It depends on ros2-lanelet2-python package.

Related links

Tests performed

lanelet2_extension_python/example.py works

Notes for reviewers

Interface changes

none.

Effects on system behavior

none.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@soblin soblin changed the title feat(lanelet2_extension_python): add python interface/bindings for autoware map and lanelet2_extension package feat(lanelet2_extension_python): add python interface/bindings for autoware map and lanelet2_extension package Dec 18, 2023
Copy link

codecov bot commented Dec 18, 2023

Codecov Report

Attention: 389 lines in your changes are missing coverage. Please review.

Comparison is base (9fb35b4) 11.31% compared to head (a7de261) 9.87%.
Report is 2 commits behind head on main.

Files Patch % Lines
tmp/lanelet2_extension_python/src/utility.cpp 0.00% 253 Missing ⚠️
...elet2_extension_python/src/regulatory_elements.cpp 0.00% 130 Missing ⚠️
tmp/lanelet2_extension_python/src/projection.cpp 0.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##             main    #221      +/-   ##
=========================================
- Coverage   11.31%   9.87%   -1.45%     
=========================================
  Files          36      39       +3     
  Lines        2660    3049     +389     
  Branches     1363    1363              
=========================================
  Hits          301     301              
- Misses       1939    2328     +389     
  Partials      420     420              
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 11.31% <ø> (ø) Carriedforward from 9fb35b4

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Clang-Tidy found issue(s) with the introduced code (1/4)

tmp/lanelet2_extension_python/src/regulatory_elements.cpp Outdated Show resolved Hide resolved
tmp/lanelet2_extension_python/src/regulatory_elements.cpp Outdated Show resolved Hide resolved
tmp/lanelet2_extension_python/src/regulatory_elements.cpp Outdated Show resolved Hide resolved
tmp/lanelet2_extension_python/src/utility.cpp Show resolved Hide resolved
tmp/lanelet2_extension_python/src/utility.cpp Show resolved Hide resolved
tmp/lanelet2_extension_python/src/utility.cpp Show resolved Hide resolved
tmp/lanelet2_extension_python/src/utility.cpp Show resolved Hide resolved
tmp/lanelet2_extension_python/src/utility.cpp Outdated Show resolved Hide resolved
tmp/lanelet2_extension_python/src/utility.cpp Outdated Show resolved Hide resolved
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Clang-Tidy found issue(s) with the introduced code (2/4)

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Clang-Tidy found issue(s) with the introduced code (3/4)

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Clang-Tidy found issue(s) with the introduced code (4/4)

tmp/lanelet2_extension_python/src/utility.cpp Outdated Show resolved Hide resolved
tmp/lanelet2_extension_python/src/utility.cpp Outdated Show resolved Hide resolved
tmp/lanelet2_extension_python/src/utility.cpp Outdated Show resolved Hide resolved
tmp/lanelet2_extension_python/src/utility.cpp Outdated Show resolved Hide resolved
@soblin soblin force-pushed the feat/python-binding branch 2 times, most recently from 19b16a5 to 52e229e Compare December 20, 2023 06:52
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Clang-Tidy found issue(s) with the introduced code (1/1)

tmp/lanelet2_extension_python/src/utility.cpp Outdated Show resolved Hide resolved
tmp/lanelet2_extension_python/src/utility.cpp Outdated Show resolved Hide resolved
tmp/lanelet2_extension_python/src/utility.cpp Outdated Show resolved Hide resolved
tmp/lanelet2_extension_python/src/utility.cpp Outdated Show resolved Hide resolved
tmp/lanelet2_extension_python/src/utility.cpp Outdated Show resolved Hide resolved
tmp/lanelet2_extension_python/src/utility.cpp Outdated Show resolved Hide resolved
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Clang-Tidy found issue(s) with the introduced code (1/1)

tmp/lanelet2_extension_python/src/utility.cpp Show resolved Hide resolved
tmp/lanelet2_extension_python/src/utility.cpp Show resolved Hide resolved
tmp/lanelet2_extension_python/src/utility.cpp Show resolved Hide resolved
tmp/lanelet2_extension_python/src/utility.cpp Show resolved Hide resolved
tmp/lanelet2_extension_python/src/utility.cpp Show resolved Hide resolved
tmp/lanelet2_extension_python/src/utility.cpp Show resolved Hide resolved
tmp/lanelet2_extension_python/src/utility.cpp Outdated Show resolved Hide resolved
tmp/lanelet2_extension_python/src/utility.cpp Outdated Show resolved Hide resolved
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Clang-Tidy found issue(s) with the introduced code (1/1)

Signed-off-by: Mamoru Sobue <[email protected]>
Signed-off-by: Mamoru Sobue <[email protected]>
Copy link
Member

@mitsudome-r mitsudome-r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mitsudome-r
Copy link
Member

The CI for clang-tidy-differential is failing, but since this is coming from extracted Macros from boost.Python, it is difficult fix the code to pass. The build check is passing, and it shouldn't have breaking changes to the functionality so I'm by-passing this check to merge the PR.

@mitsudome-r mitsudome-r merged commit 15d700b into autowarefoundation:main Jan 18, 2024
15 of 18 checks passed
@soblin soblin deleted the feat/python-binding branch January 18, 2024 11:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants