-
Notifications
You must be signed in to change notification settings - Fork 269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(autoware_mpc_lateral_controller): add resampled reference trajectory for debug purpose #1114
Merged
kyoichi-sugahara
merged 8 commits into
autowarefoundation:main
from
tier4:feat/add_debug_resampled_reference_trajectory
Sep 6, 2024
Merged
feat(autoware_mpc_lateral_controller): add resampled reference trajectory for debug purpose #1114
kyoichi-sugahara
merged 8 commits into
autowarefoundation:main
from
tier4:feat/add_debug_resampled_reference_trajectory
Sep 6, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
component:system
System design and integration. (auto-assigned)
component:control
Vehicle control algorithms and mechanisms. (auto-assigned)
component:ui
User interface, user experience, graphical user interfaces. (auto-assigned)
labels
Aug 10, 2024
kyoichi-sugahara
force-pushed
the
feat/add_debug_resampled_reference_trajectory
branch
from
August 10, 2024 13:49
35ea5b2
to
a14610b
Compare
github-actions
bot
removed
component:system
System design and integration. (auto-assigned)
component:control
Vehicle control algorithms and mechanisms. (auto-assigned)
labels
Aug 10, 2024
kyoichi-sugahara
requested review from
takayuki5168,
rej55,
satoshi-ota,
shmpwk,
danielsanchezaran,
zulfaqar-azmi-t4,
go-sakayori,
kosuke55,
mkquda,
maxime-clem,
soblin and
yhisaki
as code owners
August 10, 2024 13:52
kyoichi-sugahara
force-pushed
the
feat/add_debug_resampled_reference_trajectory
branch
from
August 10, 2024 13:55
d05f1f7
to
a14610b
Compare
1 task
kosuke55
approved these changes
Aug 11, 2024
kyoichi-sugahara
requested review from
miursh,
YoshiRi and
kminoda
as code owners
August 13, 2024 00:56
@@ -75,4 +75,5 @@ | |||
average_num: 1000 | |||
steering_offset_limit: 0.02 | |||
|
|||
debug_publish_predicted_trajectory: true # publish debug predicted trajectory in Frenet coordinate | |||
debug_publish_predicted_trajectory: true # publish predicted trajectory for debugging, considering Frenet coordinate system and delayed vehicle state |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We do not expect that the predicted trajectory in the world coordinate will be published with this comment.
github-actions
bot
removed
component:simulation
Virtual environment setups and simulations. (auto-assigned)
component:map
Map creation, storage, and loading. (auto-assigned)
component:perception
Advanced sensor data processing and environment understanding. (auto-assigned)
component:planning
Route planning, decision-making, and navigation. (auto-assigned)
labels
Aug 27, 2024
kyoichi-sugahara
removed request for
Motsu-san,
YamatoAndo,
RyuYamamoto,
KYabuuchi,
SakodaShintaro,
TaikiYamada4,
anhnv3991,
yukkysaito,
mitsudome-r and
xmfcx
August 27, 2024 05:40
takayuki5168
approved these changes
Aug 28, 2024
Signed-off-by: kyoichi-sugahara <[email protected]>
…sampled_reference_trajectory parameters Signed-off-by: kyoichi-sugahara <[email protected]>
…tion#1112)" This reverts commit 834c03f.
Signed-off-by: kyoichi-sugahara <[email protected]>
Signed-off-by: kyoichi-sugahara <[email protected]>
…ram.yaml Signed-off-by: kyoichi-sugahara <[email protected]>
Signed-off-by: kyoichi-sugahara <[email protected]> Signed-off-by: Kyoichi Sugahara <[email protected]>
kyoichi-sugahara
force-pushed
the
feat/add_debug_resampled_reference_trajectory
branch
from
September 2, 2024 09:15
8bfa0ae
to
9087823
Compare
Signed-off-by: Kyoichi Sugahara <[email protected]>
kyoichi-sugahara
deleted the
feat/add_debug_resampled_reference_trajectory
branch
September 6, 2024 06:44
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component:ui
User interface, user experience, graphical user interfaces. (auto-assigned)
tag:run-build-and-test-differential
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Necessary chenge for the PR.
Tests performed
run psim and confimed visualization with rviz
/control/trajectory_follower/controller_node_exe/debug/resampled_reference_trajectory
/control/trajectory_follower/controller_node_exe/debug/predicted_trajectory_with_delay
Effects on system behavior
Not applicable.
Interface changes
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.