Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(autoware_mpc_lateral_controller): add resampled reference trajectory for debug purpose #1114

Conversation

kyoichi-sugahara
Copy link
Contributor

Description

Necessary chenge for the PR.

Tests performed

run psim and confimed visualization with rviz
image

Line Color Description Coordinate Topic Name
🔵 Blue (dotted) Reference trajectory World /control/trajectory_follower/controller_node_exe/debug/resampled_reference_trajectory
⚪ White Predicted trajectory World /control/trajectory_follower/controller_node_exe/debug/predicted_trajectory_with_delay

Effects on system behavior

Not applicable.

Interface changes

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added component:system System design and integration. (auto-assigned) component:control Vehicle control algorithms and mechanisms. (auto-assigned) component:ui User interface, user experience, graphical user interfaces. (auto-assigned) labels Aug 10, 2024
@kyoichi-sugahara kyoichi-sugahara force-pushed the feat/add_debug_resampled_reference_trajectory branch from 35ea5b2 to a14610b Compare August 10, 2024 13:49
@github-actions github-actions bot removed component:system System design and integration. (auto-assigned) component:control Vehicle control algorithms and mechanisms. (auto-assigned) labels Aug 10, 2024
@kyoichi-sugahara kyoichi-sugahara marked this pull request as ready for review August 10, 2024 13:52
@kyoichi-sugahara kyoichi-sugahara force-pushed the feat/add_debug_resampled_reference_trajectory branch from d05f1f7 to a14610b Compare August 10, 2024 13:55
@@ -75,4 +75,5 @@
average_num: 1000
steering_offset_limit: 0.02

debug_publish_predicted_trajectory: true # publish debug predicted trajectory in Frenet coordinate
debug_publish_predicted_trajectory: true # publish predicted trajectory for debugging, considering Frenet coordinate system and delayed vehicle state
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do not expect that the predicted trajectory in the world coordinate will be published with this comment.

@github-actions github-actions bot removed component:simulation Virtual environment setups and simulations. (auto-assigned) component:map Map creation, storage, and loading. (auto-assigned) component:perception Advanced sensor data processing and environment understanding. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) labels Aug 27, 2024
@kyoichi-sugahara kyoichi-sugahara marked this pull request as draft September 2, 2024 09:09
Signed-off-by: kyoichi-sugahara <[email protected]>
Signed-off-by: Kyoichi Sugahara <[email protected]>
@kyoichi-sugahara kyoichi-sugahara force-pushed the feat/add_debug_resampled_reference_trajectory branch from 8bfa0ae to 9087823 Compare September 2, 2024 09:15
@kyoichi-sugahara kyoichi-sugahara marked this pull request as ready for review September 6, 2024 06:11
@kyoichi-sugahara kyoichi-sugahara merged commit 15f5e4a into autowarefoundation:main Sep 6, 2024
11 checks passed
@kyoichi-sugahara kyoichi-sugahara deleted the feat/add_debug_resampled_reference_trajectory branch September 6, 2024 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:ui User interface, user experience, graphical user interfaces. (auto-assigned) tag:run-build-and-test-differential
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants