fix(lane_change): parameter update #1115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]>
zulfaqar-azmi-t4
requested review from
takayuki5168,
rej55,
satoshi-ota,
shmpwk,
danielsanchezaran,
kyoichi-sugahara,
go-sakayori,
kosuke55,
mkquda,
maxime-clem,
soblin and
yhisaki
as code owners
zulfaqar-azmi-t4
added
component:planning
maxime-clem
approved these changes
Aug 13, 2024
zulfaqar-azmi-t4
deleted the
lc-disable-delta-time-and-all-predicted-path
branch
zulfaqar-azmi-t4
added a commit
to tier4/autoware_launch
that referenced
this pull request
Aug 16, 2024
Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]>
4 tasks
github-actions
bot
removed
the
component:planning
kyoichi-sugahara
pushed a commit
that referenced
this pull request
Aug 19, 2024
Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]>
shmpwk
pushed a commit
to tier4/autoware_launch
that referenced
this pull request
Aug 20, 2024
Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]>
kyoichi-sugahara
pushed a commit
to tier4/autoware_launch
that referenced
this pull request
Aug 27, 2024
Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the following two parameters:
longitudinal_velocity_delta_timefor all RSS categoryuse_all_predicted_pathCurrently due to having these parameters set, lane change have become too conservative.
In consequences, it has caused a lot of unintended lane change cancel during experiment.
These changes has been tested in experiment at odaiba and unintended cancel has been reduced and there is no critical issues observed.
Tests performed
TIER IV internal link
Effects on system behavior
Not applicable.
Interface changes
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.