Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(emergency_handler): delete package #1173

Merged
merged 2 commits into from
Sep 20, 2024
Merged

Conversation

veqcc
Copy link
Contributor

@veqcc veqcc commented Sep 19, 2024

Description

Delete emergency_handler package.

Discussion: https://github.com/orgs/autowarefoundation/discussions/4176
PR for autoware.universe: autowarefoundation/autoware.universe#8917

Tests performed

  • Psim
  • Lsim

Effects on system behavior

Interface changes

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: veqcc <[email protected]>
Copy link
Contributor

@mkuri mkuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@veqcc
Copy link
Contributor Author

veqcc commented Sep 20, 2024

@ito-san @isamu-takagi @tkimura4 @shmpwk
Hi, can anyone reveiw it? Thank you.

Copy link
Contributor

@shmpwk shmpwk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@isamu-takagi isamu-takagi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@veqcc veqcc merged commit 4cc9120 into main Sep 20, 2024
14 checks passed
@veqcc veqcc deleted the feat/delete_emergency_handler branch September 20, 2024 05:16
rej55 pushed a commit to tier4/autoware_launch that referenced this pull request Sep 20, 2024
* feat(emergency_handler): delete package

Signed-off-by: veqcc <[email protected]>
@rej55 rej55 mentioned this pull request Sep 20, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:system System design and integration. (auto-assigned) tag:run-build-and-test-differential
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants