fix(start_planner): set ignore_distance_from_lane_end param to 0.0 since it is not needed #1198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel Sanchez <[email protected]>
danielsanchezaran
requested review from
takayuki5168,
rej55,
satoshi-ota,
shmpwk,
kyoichi-sugahara,
zulfaqar-azmi-t4,
go-sakayori,
kosuke55,
mkquda,
maxime-clem,
soblin,
yhisaki and
yuki-takagi-66
as code owners
danielsanchezaran
changed the title
kyoichi-sugahara
approved these changes
Oct 25, 2024
shmpwk
approved these changes
Oct 25, 2024
danielsanchezaran
merged commit 6f7cf67
into
autowarefoundation:main
18 of 19 checks passed
danielsanchezaran
deleted the
feat/set_ignore_distance_from_lane_end_to_0
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Based on autowarefoundation/autoware.universe#4889, this parameter can be set back to 0.0, bringing back some functionality to the start planner.
Tests performed
In the video its shown how with the parameter ignore_distance_from_lane_end: 0.0, the start planner can create a shift pull out path without having to move backwards in an awkward way.
PSim
cap-.2024-10-25-16-50-55.mp4
Degradation check: TIER IV PRIVATE LINK
Effects on system behavior
Not applicable.
Interface changes
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.