Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] feat(rviz): rename camera6 & 7 #331

Closed
wants to merge 1 commit into from
Closed

[WIP] feat(rviz): rename camera6 & 7 #331

wants to merge 1 commit into from

Conversation

shmpwk
Copy link
Contributor

@shmpwk shmpwk commented Apr 27, 2023

[WIP until all AWF products agree with the rename]

Description

Rename camera by https://github.com/tier4/autoware_individual_params.jpntaxi/pull/71

  • traffic light left should be camera 6.
  • traffic light right should be camera 7

Tests performed

Psim

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@shmpwk shmpwk requested a review from tkimura4 April 27, 2023 05:08
@shmpwk
Copy link
Contributor Author

shmpwk commented Apr 27, 2023

cc. @SSSyoshida
I cannot choose you as a reviewer maybe because of some permissions?

@shmpwk shmpwk marked this pull request as draft April 27, 2023 05:22
@shmpwk shmpwk changed the title feat(rviz): rename camera6 & 7 [WIP] feat(rviz): rename camera6 & 7 Apr 27, 2023
@shmpwk
Copy link
Contributor Author

shmpwk commented Apr 27, 2023

WIP until all AWF products agree with the rename

@shmpwk shmpwk removed the request for review from tkimura4 April 27, 2023 05:27
soblin pushed a commit to soblin/autoware_launch that referenced this pull request May 7, 2023
@shmpwk shmpwk closed this May 24, 2023
@shmpwk
Copy link
Contributor Author

shmpwk commented May 24, 2023

Close this PR since there is no need to change the topic name in AWF.

rej55 pushed a commit to rej55/autoware_launch that referenced this pull request Jun 12, 2023
* chore: sync files (autowarefoundation#311)

Signed-off-by: GitHub <[email protected]>

Co-authored-by: kenji-miyake <[email protected]>

* feat: disable namespace `lane_start_bound` (autowarefoundation#314)

* feat: disable lane_bound

* fix: lane_start_bound

* feat: add center_line_arrows to disable

* ci: add sync-awf.yaml (autowarefoundation#318)

* ci: add sync-awf.yaml

Signed-off-by: Kenji Miyake <[email protected]>

* rename

Signed-off-by: Kenji Miyake <[email protected]>

* refactor(vehicle_cmd_gate): add namespace (autowarefoundation#316)

Signed-off-by: Takamasa Horibe <[email protected]>

* style: fix flake8 C417 (autowarefoundation#321)

Signed-off-by: Kenji Miyake <[email protected]>

* chore(behavior_velocity): update latest params (autowarefoundation#320)

* chore(behavior_velocity): update latest params

Signed-off-by: tanaka3 <[email protected]>

* ci(pre-commit): autofix

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* ci(pre-commit): autoupdate (autowarefoundation#324)

updates:
- [github.com/tier4/pre-commit-hooks-ros: v0.7.0 → v0.7.1](tier4/pre-commit-hooks-ros@v0.7.0...v0.7.1)
- [github.com/scop/pre-commit-shfmt: v3.4.3-1 → v3.5.0-1](scop/pre-commit-shfmt@v3.4.3-1...v3.5.0-1)

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* feat(autoware_api_launch): add rtc controller (autowarefoundation#305)

* add rtc controller

Signed-off-by: tkhmy <[email protected]>

* change line

Signed-off-by: tkhmy <[email protected]>

* change back to alphabetical order

Signed-off-by: tkhmy <[email protected]>

Co-authored-by: tier4-autoware-public-bot[bot] <98652886+tier4-autoware-public-bot[bot]@users.noreply.github.com>
Co-authored-by: kenji-miyake <[email protected]>
Co-authored-by: Hiroki OTA <[email protected]>
Co-authored-by: Kenji Miyake <[email protected]>
Co-authored-by: Takamasa Horibe <[email protected]>
Co-authored-by: taikitanaka3 <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Kah Hooi Tan <[email protected]>
maxime-clem pushed a commit to maxime-clem/autoware_launch that referenced this pull request Sep 12, 2023
badai-nguyen pushed a commit to badai-nguyen/autoware_launch that referenced this pull request Oct 31, 2023
maxime-clem pushed a commit to maxime-clem/autoware_launch that referenced this pull request Mar 5, 2024
@shmpwk shmpwk deleted the shmpwk-patch-1 branch July 3, 2024 03:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant