Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(autoware_launch): add euclidean_clustering params #445

Merged

Conversation

ismetatabay
Copy link
Member

@ismetatabay ismetatabay commented Jul 12, 2023

Description

This PR adds the euclidean_cluster config files to autoware_launch package for migrating parameters from autoware_launch.
Autoware.Universe PR: autowarefoundation/autoware.universe#4262
Releated: #4250

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@ismetatabay ismetatabay force-pushed the refactor/euclidean_clustering branch from 031864e to a4b25e9 Compare July 12, 2023 14:30
@ismetatabay ismetatabay changed the title refactor(autoware_launch): add euclidean_clustering param refactor(autoware_launch): add euclidean_clustering params Jul 12, 2023
@ismetatabay ismetatabay marked this pull request as ready for review July 12, 2023 14:44
@yukkysaito
Copy link
Contributor

@ismetatabay Thank you for your PR. It is very nice. 👍

ismetatabay and others added 4 commits July 13, 2023 11:52
@ismetatabay ismetatabay force-pushed the refactor/euclidean_clustering branch from fa5f506 to 7f89340 Compare July 13, 2023 08:52
@yukkysaito yukkysaito self-requested a review July 13, 2023 09:06
Copy link
Contributor

@yukkysaito yukkysaito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ismetatabay ismetatabay merged commit 2796d0a into autowarefoundation:main Jul 14, 2023
8 of 9 checks passed
@ismetatabay ismetatabay deleted the refactor/euclidean_clustering branch July 17, 2023 14:38
ismetatabay added a commit to ismetatabay/autoware_launch that referenced this pull request Jul 17, 2023
…oundation#445)

* add euclidean_clustering param

Signed-off-by: ismetatabay <[email protected]>

* style(pre-commit): autofix

Signed-off-by: ismetatabay <[email protected]>

* update and rearrange comments

Signed-off-by: ismetatabay <[email protected]>

* style(pre-commit): autofix

Signed-off-by: ismetatabay <[email protected]>

---------

Signed-off-by: ismetatabay <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Signed-off-by: ismetatabay <[email protected]>
soblin pushed a commit to soblin/autoware_launch that referenced this pull request Jul 25, 2023
badai-nguyen pushed a commit to badai-nguyen/autoware_launch that referenced this pull request Mar 6, 2024
mitukou1109 pushed a commit to mitukou1109/autoware_launch that referenced this pull request Jun 20, 2024
maxime-clem pushed a commit to maxime-clem/autoware_launch that referenced this pull request Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants