refactor(autoware_launch): add map_based_prediction param file #463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
Signed-off-by: ismetatabay <[email protected]>
ismetatabay
force-pushed
the
refactor/map_based_prediction
branch
from
31af294
to
d11f647
Compare
Closed
3 tasks
This was referenced Jul 20, 2023
YoshiRi
reviewed
Aug 22, 2023
| /**: | ||
| ros__parameters: | ||
| enable_delay_compensation: true | ||
| prediction_time_horizon: 7.8 #[s] |
There was a problem hiding this comment.
@ismetatabay
Hi. I found this PR changed prediction_time_horizon to 7.8 sec (original was 10.0 sec).
Is this an intended change? If you don't mind, can you tell me why you chose this value? (For us, it is more convenient to leave it at 10sec for now.)
There was a problem hiding this comment.
@YoshiRi Hi, It was a not intended change. I have no idea how its changed 10.0 to 7.8. I am creating PR now. Sorry for this.
There was a problem hiding this comment.
Here is the PR link: #523
kyoichi-sugahara
pushed a commit
that referenced
this pull request
Sep 3, 2023
Signed-off-by: GitHub <[email protected]> Signed-off-by: GitHub <[email protected]> Co-authored-by: kenji-miyake <[email protected]>
takayuki5168
referenced
this pull request
in tier4/autoware_launch
Oct 2, 2023
…parameter (#556) (#463) Signed-off-by: Takamasa Horibe <[email protected]> Co-authored-by: Takamasa Horibe <[email protected]>
mitukou1109
pushed a commit
to mitukou1109/autoware_launch
that referenced
this pull request
Jun 27, 2024
chore: sync awf-latest
maxime-clem
pushed a commit
to maxime-clem/autoware_launch
that referenced
this pull request
Sep 3, 2024
…parameter (autowarefoundation#556) (autowarefoundation#463) Signed-off-by: Takamasa Horibe <[email protected]> Co-authored-by: Takamasa Horibe <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds map_based_prediction.param.yaml to autoware_launch config directory
Releated:
Tests performed
Not applicable.
Effects on system behavior
Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.