-
Notifications
You must be signed in to change notification settings - Fork 269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(autoware_launch): add map_based_prediction param file #463
refactor(autoware_launch): add map_based_prediction param file #463
Conversation
Signed-off-by: ismetatabay <[email protected]>
31af294
to
d11f647
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/**: | ||
ros__parameters: | ||
enable_delay_compensation: true | ||
prediction_time_horizon: 7.8 #[s] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ismetatabay
Hi. I found this PR changed prediction_time_horizon to 7.8 sec (original was 10.0 sec).
Is this an intended change? If you don't mind, can you tell me why you chose this value? (For us, it is more convenient to leave it at 10sec for now.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@YoshiRi Hi, It was a not intended change. I have no idea how its changed 10.0 to 7.8. I am creating PR now. Sorry for this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here is the PR link: #523
Signed-off-by: GitHub <[email protected]> Signed-off-by: GitHub <[email protected]> Co-authored-by: kenji-miyake <[email protected]>
…parameter (#556) (#463) Signed-off-by: Takamasa Horibe <[email protected]> Co-authored-by: Takamasa Horibe <[email protected]>
chore: sync awf-latest
…parameter (autowarefoundation#556) (autowarefoundation#463) Signed-off-by: Takamasa Horibe <[email protected]> Co-authored-by: Takamasa Horibe <[email protected]>
Description
This PR adds map_based_prediction.param.yaml to autoware_launch config directory
Releated:
Tests performed
Not applicable.
Effects on system behavior
Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.