Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(rviz_config): add debug marker group #541

Merged
merged 1 commit into from
Aug 31, 2023

Conversation

TakaHoribe
Copy link
Contributor

@TakaHoribe TakaHoribe commented Aug 30, 2023

Description

Add a debug marker group. Please enable the checkbox when you want to visualize detailed information for debugging/development.

Now it is empty, please add some markers in each module.

image

Tests performed

run psim

Effects on system behavior

None

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@TakaHoribe TakaHoribe enabled auto-merge (squash) August 30, 2023 09:43
Copy link
Contributor

@kminoda kminoda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Just left one suggestion for localization

Comment on lines +2431 to +2434
- Class: rviz_common/Group
Displays: ~
Enabled: true
Name: Localization
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Class: rviz_common/Group
Displays: ~
Enabled: true
Name: Localization
- Class: rviz_common/Group
Enabled: true
Name: Localization
Displays:
- Alpha: 0.9990000128746033
Autocompute Intensity Bounds: true
Autocompute Value Bounds:
Max Value: 10
Min Value: -10
Value: true
Axis: Z
Channel Name: intensity
Class: rviz_default_plugins/PointCloud2
Color: 85; 255; 0
Color Transformer: FlatColor
Decay Time: 0
Enabled: true
Invert Rainbow: false
Max Color: 85; 255; 127
Max Intensity: 0
Min Color: 0; 0; 0
Min Intensity: 0
Name: NDT pointclouds
Position Transformer: XYZ
Selectable: false
Size (Pixels): 10
Size (m): 0.5
Style: Squares
Topic:
Depth: 5
Durability Policy: Volatile
Filter size: 10
History Policy: Keep Last
Reliability Policy: Reliable
Value: /localization/pose_estimator/points_aligned
Use Fixed Frame: true
Use rainbow: true
Value: true
- Alpha: 1
Autocompute Intensity Bounds: true
Autocompute Value Bounds:
Max Value: 10
Min Value: -10
Value: true
Axis: Z
Channel Name: intensity
Class: rviz_default_plugins/PointCloud2
Color: 255; 255; 255
Color Transformer: ""
Decay Time: 0
Enabled: true
Invert Rainbow: false
Max Color: 255; 255; 255
Max Intensity: 4096
Min Color: 0; 0; 0
Min Intensity: 0
Name: NDTLoadedPCDMap
Position Transformer: ""
Selectable: true
Size (Pixels): 3
Size (m): 0.1
Style: Flat Squares
Topic:
Depth: 5
Durability Policy: Volatile
Filter size: 10
History Policy: Keep Last
Reliability Policy: Reliable
Value: /localization/pose_estimator/debug/loaded_pointcloud_map
Use Fixed Frame: true
Use rainbow: true
Value: true
- Buffer Size: 200
Class: rviz_plugins::PoseHistory
Enabled: true
Line:
Alpha: 0.9990000128746033
Color: 170; 255; 127
Value: true
Width: 0.10000000149011612
Name: NDTPoseHistory
Topic:
Depth: 5
Durability Policy: Volatile
Filter size: 10
History Policy: Keep Last
Reliability Policy: Reliable
Value: /localization/pose_estimator/pose
Value: true
- Buffer Size: 1000
Class: rviz_plugins::PoseHistory
Enabled: true
Line:
Alpha: 0.9990000128746033
Color: 0; 255; 255
Value: true
Width: 0.10000000149011612
Name: EKFPoseHistory
Topic:
Depth: 5
Durability Policy: Volatile
Filter size: 10
History Policy: Keep Last
Reliability Policy: Reliable
Value: /localization/pose_twist_fusion_filter/pose
Value: true

@TakaHoribe TakaHoribe merged commit 1e48981 into autowarefoundation:main Aug 31, 2023
10 of 11 checks passed
@TakaHoribe TakaHoribe deleted the rviz-debug-group branch August 31, 2023 00:31
@kminoda
Copy link
Contributor

kminoda commented Aug 31, 2023

Oh it's auto merged 😆

kyoichi-sugahara pushed a commit that referenced this pull request Sep 3, 2023
kyoichi-sugahara pushed a commit that referenced this pull request Sep 3, 2023
soblin pushed a commit to soblin/autoware_launch that referenced this pull request Nov 18, 2023
…utowarefoundation#614)

* chore(rviz_config): add debug marker group (autowarefoundation#541)

Signed-off-by: Takamasa Horibe <[email protected]>

* feat: add localization debug topic

Signed-off-by: 1222-takeshi <[email protected]>

* feat: add debug group for awsim.rviz

Signed-off-by: 1222-takeshi <[email protected]>

---------

Signed-off-by: Takamasa Horibe <[email protected]>
Signed-off-by: 1222-takeshi <[email protected]>
Co-authored-by: Takamasa Horibe <[email protected]>
maxime-clem pushed a commit to maxime-clem/autoware_launch that referenced this pull request Sep 4, 2024
…e situation (autowarefoundation#1113) (autowarefoundation#541)

* feat(static_obstacle_avoidance): change policy for ambiguous avoidance situation



* fix(static_obstacle_avoidance): tune ambiguous vehicle ignore area



---------

Signed-off-by: satoshi-ota <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants