Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(duplicated_node_checker): add duplicated node names to msg #651

Merged
merged 1 commit into from
Oct 23, 2023

Conversation

kyoichi-sugahara
Copy link
Contributor

Description

necesary change for the PR

Tests performed

run scenario_simulator_v2

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: kyoichi-sugahara <[email protected]>
@kyoichi-sugahara
Copy link
Contributor Author

@shmpwk
can you approve this PR too?

shmpwk
shmpwk previously approved these changes Oct 23, 2023
Copy link
Contributor

@shmpwk shmpwk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kyoichi-sugahara kyoichi-sugahara merged commit 5a04d1c into main Oct 23, 2023
10 of 11 checks passed
@kyoichi-sugahara kyoichi-sugahara deleted the feat/add_duplicated_nodes_to_msg branch October 23, 2023 11:27
soblin pushed a commit to soblin/autoware_launch that referenced this pull request Nov 18, 2023
…tart_goal

feat: update start goal planner v0.43.2
takayuki5168 pushed a commit to tier4/autoware_launch that referenced this pull request Nov 26, 2023
sykwer pushed a commit to sykwer/autoware_launch that referenced this pull request Jan 3, 2024
…alization_launch (autowarefoundation#651)

* remove localization_launch

Signed-off-by: kminoda <[email protected]>

* Update readme

* remove localization_launch from packages.xml

* provide pointcloud_container_name, which should be customized depending on vehicles

Signed-off-by: kminoda <[email protected]>

Signed-off-by: kminoda <[email protected]>
maxime-clem pushed a commit to maxime-clem/autoware_launch that referenced this pull request May 21, 2024
* feat: add split launch

* style(pre-commit): autofix

---------

Co-authored-by: 0x126 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants