Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(ekf_localizer): add Simple1DFilter params to parameter file #710

Merged
merged 2 commits into from
Jan 15, 2024
Merged

refactor(ekf_localizer): add Simple1DFilter params to parameter file #710

merged 2 commits into from
Jan 15, 2024

Conversation

meliketanrikulu
Copy link
Contributor

@meliketanrikulu meliketanrikulu commented Nov 28, 2023

Description

Simple1DFilter parameters will be added to the parameter file to be able to change these parameters from the parameter file.

This PR related this PR: autowarefoundation/autoware.universe#5707

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@meliketanrikulu meliketanrikulu changed the title feat(ekf_localizer): Add Simple1DFilter params to parameter file refactor(ekf_localizer): Add Simple1DFilter params to parameter file Dec 21, 2023
@meliketanrikulu meliketanrikulu changed the title refactor(ekf_localizer): Add Simple1DFilter params to parameter file refactor(ekf_localizer): add Simple1DFilter params to parameter file Dec 21, 2023
Copy link
Contributor

@kminoda kminoda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kminoda kminoda enabled auto-merge (squash) December 21, 2023 12:38
@kminoda
Copy link
Contributor

kminoda commented Dec 21, 2023

@meliketanrikulu Please fix pre-commit

@KYabuuchi KYabuuchi self-requested a review December 27, 2023 00:15
@KYabuuchi KYabuuchi self-requested a review January 15, 2024 05:00
@KYabuuchi
Copy link
Contributor

@kminoda This PR has long been left undone. This is not good so I have committed myself to it.
Please review and approve this 🙏

@KYabuuchi KYabuuchi merged commit e7c0f89 into autowarefoundation:main Jan 15, 2024
9 of 10 checks passed
maxime-clem pushed a commit to maxime-clem/autoware_launch that referenced this pull request Feb 6, 2024
…behind the ego vehicle (autowarefoundation#710)

Signed-off-by: Owen-Liuyuxuan <[email protected]>
Co-authored-by: Owen-Liuyuxuan <[email protected]>
@meliketanrikulu meliketanrikulu self-assigned this May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants