Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(ndt_scan_matcher): hierarchize parameters #830

Conversation

YamatoAndo
Copy link
Contributor

Description

see autowarefoundation/autoware.universe#6208

Tests performed

see autowarefoundation/autoware.universe#6208

Effects on system behavior

see autowarefoundation/autoware.universe#6208

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Yamato Ando <[email protected]>
Copy link
Contributor

@SakodaShintaro SakodaShintaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I executed the logging_simulator using AWSIM data and confirmed that autoware works with almost the same evaluation values as before.

I think it is a good idea to separate the code for hyperparameter settings.

@YamatoAndo YamatoAndo merged commit eff6353 into autowarefoundation:main Feb 1, 2024
9 of 10 checks passed
maxime-clem pushed a commit to maxime-clem/autoware_launch that referenced this pull request May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants