Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(image_projection_based_fusion): rework params #845

Conversation

badai-nguyen
Copy link
Contributor

@badai-nguyen badai-nguyen commented Feb 1, 2024

Description

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@Shin-kyoto
Copy link
Contributor

@badai-nguyen
Could you please rebase to the latest?

Copy link
Contributor

@Shin-kyoto Shin-kyoto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@badai-nguyen

Please add these params to https://github.com/autowarefoundation/autoware_launch/blob/main/autoware_launch/config/perception/object_recognition/detection/lidar_model/pointpainting.param.yaml, too

    # fusion interface common params
    debug_mode: false
    image_buffer_size: 15
    filter_scope_min_x: -100.0
    filter_scope_min_y: -100.0
    filter_scope_min_z: -100.0
    filter_scope_max_x: 100.0
    filter_scope_max_y: 100.0
    filter_scope_max_z: 100.0

That is because pointpainting uses roi_sync_param in https://github.com/autowarefoundation/autoware.universe/blob/1ed6fac11a9851c12ede1ec34409204d799d9863/perception/image_projection_based_fusion/launch/pointpainting_fusion.launch.xml#L26

I checked this PR with evaluator, and I got the error below.

[ERROR] [launch_ros.actions.load_composable_nodes]: Failed to load node 'pointpainting' of type 'image_projection_based_fusion::PointPaintingFusionNode' in container 'pointcloud_container': Component constructor threw an exception: Statically typed parameter 'filter_scope_min_x' must be initialized.

And please run the evaluator on the condition that "perception_mode" is "camera_lidar_fusion" and "lidar_detection_model" is "pointpainting", and paste the link to the result of evaluator.
This example will be helpful for you.

Copy link

stale bot commented Apr 22, 2024

This pull request has been automatically marked as stale because it has not had recent activity.

@stale stale bot added the stale label Apr 22, 2024
maxime-clem pushed a commit to maxime-clem/autoware_launch that referenced this pull request May 13, 2024
…herry-pick-avoidance-pr

fix(avoidance): cherry pick PRs
@badai-nguyen badai-nguyen force-pushed the refactor/image_projection_param branch from ea36f9e to 52f156b Compare May 30, 2024 08:51
@badai-nguyen badai-nguyen force-pushed the refactor/image_projection_param branch from 52f156b to 2981cc7 Compare May 30, 2024 08:56
@stale stale bot removed the stale label May 30, 2024
@github-actions github-actions bot added the component:perception Advanced sensor data processing and environment understanding. (auto-assigned) label May 30, 2024
@Shin-kyoto Shin-kyoto self-requested a review May 30, 2024 09:23
@Shin-kyoto
Copy link
Contributor

Shin-kyoto commented May 30, 2024

@badai-nguyen

I did NOT run autoware with this PR. I checked the code only. Please check this PR runs correctly.

Copy link
Contributor

@miursh miursh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Could you change the file in autoware.universe and launch files as well?

@badai-nguyen
Copy link
Contributor Author

@miursh I fogot to link the autoware.universe PR. I already changed here autowarefoundation/autoware.universe#6289. Could you review it as well?

@badai-nguyen badai-nguyen merged commit 322c686 into autowarefoundation:main May 31, 2024
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:perception Advanced sensor data processing and environment understanding. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants