Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(localization): add lidar_marker_localizer #861

Merged

Conversation

YamatoAndo
Copy link
Contributor

@YamatoAndo YamatoAndo commented Feb 7, 2024

Description

see autowarefoundation/autoware.universe#5573

Related links

see autowarefoundation/autoware.universe#5573

Tests performed

see autowarefoundation/autoware.universe#5573

Notes for reviewers

see autowarefoundation/autoware.universe#5573

Interface changes

see autowarefoundation/autoware.universe#5573

Effects on system behavior

see autowarefoundation/autoware.universe#5573

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Yamato Ando <[email protected]>
t4-adc pushed a commit to tier4/autoware_launch that referenced this pull request Mar 21, 2024
@YamatoAndo YamatoAndo force-pushed the feat/add_lidar_marker_localizer branch from b7b76fa to 6a5b16b Compare March 28, 2024 09:52
@github-actions github-actions bot added the component:localization Vehicle's position determination in its environment. (auto-assigned) label May 28, 2024
yuki-takagi-66 pushed a commit to tier4/autoware_launch that referenced this pull request Jun 5, 2024
Copy link
Contributor

@SakodaShintaro SakodaShintaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@YamatoAndo YamatoAndo merged commit 81800f5 into autowarefoundation:main Aug 23, 2024
17 checks passed
kyoichi-sugahara pushed a commit to tier4/autoware_launch that referenced this pull request Aug 27, 2024
* add config files

Signed-off-by: Yamato Ando <[email protected]>

* style(pre-commit): autofix

* add param marker_height_from_ground

Signed-off-by: Yamato Ando <[email protected]>

* save log param

Signed-off-by: Yamato Ando <[email protected]>

* apply PointXYZIRC

Signed-off-by: Yamato Ando <[email protected]>

* to pass spell-check

Signed-off-by: Yamato Ando <[email protected]>

* refactor

Signed-off-by: Yamato Ando <[email protected]>

* change flag

Signed-off-by: Yamato Ando <[email protected]>

* fix typo

Signed-off-by: Yamato Ando <[email protected]>

---------

Signed-off-by: Yamato Ando <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: SakodaShintaro <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:localization Vehicle's position determination in its environment. (auto-assigned) tag:run-build-and-test-differential
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants