Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(api): add launch option #960

Merged
merged 1 commit into from
Apr 22, 2024
Merged

feat(api): add launch option #960

merged 1 commit into from
Apr 22, 2024

Conversation

h-ohta
Copy link
Contributor

@h-ohta h-ohta commented Apr 22, 2024

Description

add option for api launch

Related links

TIERIV_INTERNAL_LINK: https://star4.slack.com/archives/C4P0NSMB5/p1713483635225589

Tests performed

I confirmed by following steps.

launch_api = true

Use command below

ros2 launch autoware_launch autoware.launch.xml vehicle_model:=sample_vehicle sensor_model:=sample_sensor_kit map_path:=$HOME/map/sample_map rviz:=false launch_vehicle:=false launch_system:=false launch_map:=false launch_sensing:=false launch_sensing_driver:=false launch_localization:=false launch_perception:=false launch_planning:=false launch_control:=false launch_api:=true

And I found that only api launches.

launch_api = false

Use command below

ros2 launch autoware_launch autoware.launch.xml vehicle_model:=sample_vehicle sensor_model:=sample_sensor_kit map_path:=$HOME/map/sample_map rviz:=false launch_vehicle:=false launch_system:=false launch_map:=false launch_sensing:=false launch_sensing_driver:=false launch_localization:=false launch_perception:=false launch_planning:=false launch_control:=false launch_api:=false

And I found that all modules including api does not launch.

Notes for reviewers

Interface changes

Effects on system behavior

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@h-ohta h-ohta marked this pull request as ready for review April 22, 2024 06:18
Copy link
Contributor

@yukkysaito yukkysaito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@h-ohta h-ohta merged commit 112e7e6 into main Apr 22, 2024
12 of 13 checks passed
@h-ohta h-ohta deleted the feat/api_arg branch April 22, 2024 07:16
yuki-takagi-66 pushed a commit to tier4/autoware_launch that referenced this pull request Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants