Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(awsim_labs_vehicle_launch): add a new vehicle_model with raw_vehicle_command_converter #1

Merged

Conversation

beyzanurkaya
Copy link

@beyzanurkaya beyzanurkaya commented Aug 19, 2024

Description

Fixes: autowarefoundation/autoware#5106

Related links

awsim_v1.2 binary: https://github.com/autowarefoundation/AWSIM-Labs/releases/download/v1.2.1/awsim_labs_v1.2.1.zip
binary with VPP: https://drive.google.com/file/d/1Xr3mDZU8Q0EDwy1kJkG-wD1mvoMypTBe/view?usp=drive_link

Tests performed

VPPIntegration.mp4

Notes for reviewers

  • Please set launch_vehicle_interface to true in e2e_simulator.launch.xml
  • When you launch e2e_simulator.launch.xml set the vehicle_model to awsim_labs_vehicle

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@beyzanurkaya beyzanurkaya marked this pull request as ready for review August 19, 2024 15:20
@beyzanurkaya
Copy link
Author

@mozhoku Could you please test the PR and share your thoughts?

FYI: @xmfcx

@mozhoku
Copy link

mozhoku commented Aug 20, 2024

I've tested the PR and it works when I follow the provided steps. 👍

Copy link

@mozhoku mozhoku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@xmfcx xmfcx merged commit 53715bd into autowarefoundation:main Sep 3, 2024
2 checks passed
@xmfcx
Copy link

xmfcx commented Sep 3, 2024

Please create a PR in autoware_launch to refer to this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create vehicle_model with raw_vehicle_command_converter for AWSIM
3 participants