Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(nebula_node_container): enhance logging #86

Merged
merged 1 commit into from
Jan 29, 2024
Merged

Conversation

kminoda
Copy link
Contributor

@kminoda kminoda commented Jan 19, 2024

Description

Enhance logging of nebula_node_container.

  • Add glog_component in nebula_node_container so that all the LiDAR preprocessing container will have glog enabled
  • Change logging configuration from "screen" to "both" so that the log will be written to the log file as well as terminal

Related: tier4/aip_launcher#199

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@kminoda
Copy link
Contributor Author

kminoda commented Jan 19, 2024

@knzo25 Hi, would you mind reviewing this PR?

Copy link
Contributor

@drwnz drwnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kminoda kminoda merged commit af0d32b into main Jan 29, 2024
12 of 13 checks passed
@kminoda kminoda deleted the chore/enhance_logging branch January 29, 2024 04:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants