chore(nebula_node_container): make launcher work with Nebula v0.2.0 #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Max SCHMELLER <[email protected]>
4 tasks
mojomex
changed the title
mojomex
changed the title
4 tasks
xmfcx
approved these changes
Oct 3, 2024
There was a problem hiding this comment.
Tested the sample_sensor_kit_launch counterpart in autowarefoundation/autoware#5275 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR makes the launcher changes necessary for the Nebula v0.2.0 release to work.
This PR is part of a 3-PR group that has to be merged in tandem. The other two are:
See
for more information on the tests performed and expected impacts on Autoware.
I will merge all PRs in tandem once all of them get approved and have passing CI.
Please do not merge them independently.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.