-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(udp_socket): allow user to set internal socket buffer size #1
feat(udp_socket): allow user to set internal socket buffer size #1
Conversation
f86566a
to
ec677fd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some small aesthetics-related comments
501ef05
to
df82534
Compare
Signed-off-by: Max SCHMELLER <[email protected]>
Co-authored-by: Kenzo Lobos Tsunekawa <[email protected]> Signed-off-by: Max SCHMELLER <[email protected]>
Signed-off-by: Max SCHMELLER <[email protected]>
df82534
to
86b9aae
Compare
Sorry for the force-pushes, I was working on different machines that had different case styles of my name, failing DCO. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
8a93ae0
into
autowarefoundation:mutable-buffer-in-udp-callback
* feat(udp_socket): allow user to set internal socket buffer size Signed-off-by: Max SCHMELLER <[email protected]> * chore: fix typo Co-authored-by: Kenzo Lobos Tsunekawa <[email protected]> Signed-off-by: Max SCHMELLER <[email protected]> * chore(udp_socket): fixed include <>/"" and reordered includes Signed-off-by: Max SCHMELLER <[email protected]> --------- Signed-off-by: Max SCHMELLER <[email protected]> Co-authored-by: Kenzo Lobos Tsunekawa <[email protected]>
PR Type
Related Links
SO_RCVBUF
automatically tier4/nebula#186 -- Nebula PR requiring this featureDescription
This PR adds the ability to set the size of
SO_RECVBUF
in the underlying system's UDP socket used byUdpSocket
.Calling the new
setKernelBufferSize(n_bytes)
member function of a UdpSocket tries to set the corresponding option in Boost ASIO and returns abool
that indicates if the operation was successful.Code not actively invoking this feature is unaffected.
Pre-Review Checklist for the PR Author
PR Author should check the checkboxes below when creating the PR.
Checklist for the PR Reviewer
Reviewers should check the checkboxes below before approval.
Post-Review Checklist for the PR Author
PR Author should check the checkboxes below before merging.
CI Checks