feat(udp_socket): allow user to set internal socket buffer size #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mojomex
force-pushed
the
feat-set-rmem
branch
from
f86566a
to
ec677fd
Compare
knzo25
reviewed
Sep 3, 2024
knzo25
reviewed
Sep 3, 2024
knzo25
requested changes
Sep 3, 2024
mojomex
force-pushed
the
feat-set-rmem
branch
3 times, most recently
from
501ef05
to
df82534
Compare
Signed-off-by: Max SCHMELLER <[email protected]>
Co-authored-by: Kenzo Lobos Tsunekawa <[email protected]> Signed-off-by: Max SCHMELLER <[email protected]>
Signed-off-by: Max SCHMELLER <[email protected]>
mojomex
force-pushed
the
feat-set-rmem
branch
from
df82534
to
86b9aae
Compare
|
Sorry for the force-pushes, I was working on different machines that had different case styles of my name, failing DCO. |
mojomex
merged commit 8a93ae0
into
autowarefoundation:mutable-buffer-in-udp-callback
4 checks passed
5 tasks
mojomex
added a commit
that referenced
this pull request
Sep 19, 2024
* feat(udp_socket): allow user to set internal socket buffer size Signed-off-by: Max SCHMELLER <[email protected]> * chore: fix typo Co-authored-by: Kenzo Lobos Tsunekawa <[email protected]> Signed-off-by: Max SCHMELLER <[email protected]> * chore(udp_socket): fixed include <>/"" and reordered includes Signed-off-by: Max SCHMELLER <[email protected]> --------- Signed-off-by: Max SCHMELLER <[email protected]> Co-authored-by: Kenzo Lobos Tsunekawa <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
Related Links
SO_RCVBUFautomatically tier4/nebula#186 -- Nebula PR requiring this featureDescription
This PR adds the ability to set the size of
SO_RECVBUFin the underlying system's UDP socket used byUdpSocket.Calling the new
setKernelBufferSize(n_bytes)member function of a UdpSocket tries to set the corresponding option in Boost ASIO and returns aboolthat indicates if the operation was successful.Code not actively invoking this feature is unaffected.
Pre-Review Checklist for the PR Author
PR Author should check the checkboxes below when creating the PR.
Checklist for the PR Reviewer
Reviewers should check the checkboxes below before approval.
Post-Review Checklist for the PR Author
PR Author should check the checkboxes below before merging.
CI Checks