-
Notifications
You must be signed in to change notification settings - Fork 376
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Subnet 9000 Replacement #1885
Merged
Merged
Subnet 9000 Replacement #1885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashucoder9
requested review from
laviniat1996,
amandamarquis1 and
a team
as code owners
September 12, 2024 09:02
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
ashucoder9
added
the
DO NOT MERGE
This PR is not meant to be merged in its current state
label
Sep 12, 2024
Signed-off-by: Owen <[email protected]>
…he-docs into subnet-9000-replacement
Signed-off-by: Owen <[email protected]>
Closed
ashucoder9
commented
Sep 13, 2024
Closed
Closed
owenwahlgren
previously approved these changes
Sep 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Co-authored-by: Meaghan FitzGerald <[email protected]> Signed-off-by: Ashutosh Tripathi <[email protected]>
@owenwahlgren can you approve the PR and merge? |
owenwahlgren
approved these changes
Sep 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me 🫡
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PS: manually update the words wherever a better context is required while making the changes.
also, the remote docs are not updated yet (specifically cross-chain folder atm).