use libevm: params, core/vm, eth/tracers/* + some of core/types #662
+2,175
−33,473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ARR4N
reviewed
Oct 2, 2024
params/config.go
Outdated
| CortinaBlockTimestamp: utils.NewUint64(0), | ||
| DurangoBlockTimestamp: utils.NewUint64(0), | ||
| EtnaTimestamp: utils.NewUint64(0), | ||
| _ = do_init() // XXX: is (temporarily) here because type registeration must proceed the call to .Rules() |
darioush
force-pushed
the
use-libevm
branch
2 times, most recently
from
f127a63
to
0976d50
Compare
darioush
changed the title
darioush
commented
Oct 14, 2024
Comment on lines
+74
to
+75
| // GetPredicateResults returns an byte array result of verifying the predicates | ||
| // of the given block. |
There was a problem hiding this comment.
Suggested change
| // GetPredicateResults returns an byte array result of verifying the predicates | |
| // of the given block. | |
| // GetPredicateResultsBytes returns an byte array result of verifying the predicates | |
| // of the given block. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Improved maintainability and reducing copies of upstream packages with modified code. This reduces our tech debt by entirely using the upstream vm module + jump tables.
As we have the
libevmbranch to test these changes, I would like to defer some of the following cleanups to future PRs:How this works
Uses
core/vm, andeth/tracer/*packages from https://github.com/ava-labs/libevm as a module that expands geth code without making destructive modifications instead of using code copied from upstream and modified in this repo.Instead, the avalanche specific functionality such as precompiles are re-introduced through the hooks provided by libevm
How this was tested
CI, reprocessed historical blocks of fuji/mainnet (probably should run this again with additional switches using upstream fork names)