feat: pseudo.Type RLP round-tripping
#43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ARR4N
changed the title
types.StateAccount pseudo-generic payloadpseudo.Type RLP round-tripping
ARR4N
requested review from
a team,
darioush,
ceyonur and
michaelkaplan13
and removed request for
a team
darioush
approved these changes
Oct 1, 2024
ARR4N
added a commit
that referenced
this pull request
Oct 2, 2024
Some of the changes in the full commit history were merged into `libevm` as part of #43 in `336a289` and then merged back into this branch as `5b15698`. Cherry-picking commits was not possible as some touched both halves of the changes; the squash-merges will, however, make this convoluted history irrelevant. * feat: `types.StateAccount` pseudo-generic payload * feat: registration of `StateAccount` payload type * chore: mark `eth/tracers/logger` flaky * chore: copyright header + `gci` * test: lock default `types.SlimAccount` RLP encoding * feat: `vm.SlimAccount.Extra` from `StateAccount` equiv * chore: placate the linter * test: `pseudo.Type.EncodeRLP()` * test: `pseudo.Type.DecodeRLP()` * fix: `pseudo.Type.DecodeRLP()` with non-pointer type * feat: `pseudo.Type.IsZero()` and `Type.Equal(*Type)` * feat: `types.StateAccountExtra.DecodeRLP()` * fix: remove unnecessary `StateAccountExtra.clone()` * refactor: readability * feat: `pseudo.Type.Format()` implements `fmt.Formatter`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Prerequisite for #44, which introduces a
pseudo.Typeextra payload intotypes.StateAccount.How this works
The new
pseudo.Type.{Encode,Decode}RLP()methods plumb through to their concrete payload in the same way as JSON round-tripping was implemented.Two minor methods
Type.IsZero()andEqual(*pseudo.Type)are also introduced as prerequisites for #44.How this was tested
Fuzzing a
types.Headerand confirming that it produces the identical RLP when encoded while carried inside apseudo.Type. A round trip decoding of the RLP into a newpseudo.Typethen tests decoding.