chore: rename Go module as github.com/ava-labs/libevm
#60
+3,650
−3,642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ARR4N
force-pushed
the
arr4n/rename-module
branch
3 times, most recently
from
a01599a
to
4c8d4bd
Compare
ARR4N
requested review from
a team,
darioush,
ceyonur and
michaelkaplan13
and removed request for
a team
darioush
approved these changes
Oct 14, 2024
Workflow: c1fc594f020d23958b641a4e5a856b6e52c49d3bece94b95594864db16c1b0fc on branch main
…34ac16627a1_workflow-c1fc594f020d23958b641a4e5a856b6e52c49d3bece94b95594864db16c1b0fc-main' into arr4n/rename-module
Linter: - Block imports of `ethereum/go-ethereum` upstream module - Disable `goimports` checks on upstream code Go: - Update flaky-test regex - Run flaky and non-flaky tests in different steps as this makes it easier to spot incorrect regex Upstream delta: - Use env var in workflow instead of `libevm-base` tag -> base changes atomically with the update commit
ARR4N
force-pushed
the
arr4n/rename-module
branch
from
4c8d4bd
to
5c66352
Compare
|
Note that the force push after review was to use a signed commit for the automated renaming. The comparison shows that the push was a no-op with respect to the outcome—the only difference is the new renaming workflow to sign commits (i.e. the reason the push was needed) as reviewed and merged in #61. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Completes renaming of the Go module to
github.com/ava-labs/libevmto no longer clash with the truegithub.com/ethereum/go-ethereumand require areplacedirective.How this works
The merge commit
d6d53f9merges therenamed-go-modulebranch, resolves conflicts (imports only) and also renames all other imports using the samesedregex/replace as the auto-renaming workflow. Completing the import renaming in a single commit made it self-contained and able to build and pass all tests.The other commit makes all necessary CI changes to accomodate for the renaming. Of note, it removes use of the
libevm-basetag and instead includes the commit hash in the relevant workflow; this allows for an atomic change of base commit at time of merging.How this was tested
Renaming of the module is confirmed by inspection of
go.mod. Updating all internal import paths is confirmed by an updated linter that blocks modules, guaranteeing that theethereum/go-ethereummodule isn't imported.The
libevm deltaworkflow can also be inspected to see that the current diff doesn't show any module-name differences, while the diff againstmaindoes.All regular CI (Go build + test) passes as expected.
Merge checklist
a7f08d0with a signed equivalent from feat: signed commit when renaming upstream module #61