React 18 StrictMode #369

zvi1977 · 2022-05-22T09:29:02Z

Hi,
Are there plans to support React 18 ?

t3db0t · 2022-05-24T14:39:05Z

Seconding this, I'm getting unable to resolve dependency tree when trying to install on a new React project...

wintercounter · 2022-05-28T20:31:04Z

It installs fine for me, try with --legacy-peer-deps flag.

zvi1977 · 2022-05-29T12:23:09Z

It installs fine for me, try with --legacy-peer-deps flag.

Thanks , indeed it installs with this flag , however, in runtime I realized that use-http doesn't work with React.StrictMode and React 18...
found a related issue :
#368

krishnasaga · 2022-12-03T18:06:19Z

Did any one found the root cause of what causing this ?

krishnasaga · 2022-12-04T13:44:09Z

zvi1977 I added my findings of root cause here #368 (comment).

#368

enriquemorenotent · 2023-01-20T18:43:35Z

How is it even possible that this library is not supporting v18? :O

krishnasaga · 2023-01-23T18:28:45Z

@enriquemorenotent what do you men by not supporting ?

enriquemorenotent · 2023-01-23T21:38:42Z

@krishnasaga Have you tried doing npm i use-http on a React v18 app? It will give you an error.

You can "force it", of course. But it doesn't inspire a lot of confidence.

krishnasaga · 2023-01-23T23:50:40Z

@enriquemorenotent There reason you receive this error is because of this

use-http/package.json

Lines 17 to 19 in 031b2ee

    
           "peerDependencies": { 
        
             "react": "^16.13.1 || ^17.0.0", 
        
             "react-dom": "^16.13.1 || ^17.0.0"

it is explicitly mentioned in pear dependencies as react 16 or react 17

By resolving this issue and successfully passing all the tests. use-http can start supporting react 18. then we can update the pear dependencies so you will not get that error when you install it.

enriquemorenotent · 2023-01-23T23:54:12Z

@krishnasaga I am not sure I understand what you are asking me...

flo-sch · 2023-01-24T09:27:02Z

It will give you an error.

More a warning I would say, this library has not been certified compatible with React v18 yet.
I have been using it with React v18 without too much problems other than this issue here with <StrictMode />

If you happen to know a way to make it fully compatible with React v18, feel free to contribute, this is Open Source ;)

enriquemorenotent · 2023-01-24T11:45:02Z

@flo-sch I would call it a warning, if it actually installed the package. But since it doesn't, I call it an error.

Sadly no, I have no idea how to make it work.

flo-sch · 2023-01-24T12:03:49Z

Oh okay, I have not used npm in years now, did not know it would prevent to install it 🤷
yarn just warns about the version potentially not supported. the --force flag of npm should work until this issue is resolved

krishnasaga · 2023-03-13T16:21:47Z

@alex-cory there is a duplicate of this thread which I have mentioned. If it making sense to close one of those could you do it please ?

alex-cory · 2023-03-14T13:37:21Z

If someone creates a PR for this I'll gladly accept it.

krishnasaga · 2023-04-09T18:51:24Z

@alex-cory Can I have your permission to copy the code of use-http to use directly in my project without importing, so I can have have that fix in my project without needing to depend on the release and also allows me to battle test it against multiple scenarios.

csvan · 2023-04-25T10:55:46Z

@krishnasaga it's MIT licensed, you already have permission.

TannerS · 2023-06-29T23:10:46Z

Is there a timeline on react 18 support? our company pipeline doesnt allow force or using legacy deps when doing npm install

wintercounter · 2023-06-30T05:57:27Z

Lol, that's something I never heard of. For me 9 out of 10 projects have to use --legacy-peer-deps. Just because a package hasn't been updated since the release of npm v7 it doesn't mean it's a security risk.

TannerS · 2023-06-30T12:35:57Z

I'm not saying your wrong, but I am gonna say we don't have much of a choice. It's a pipeline hundreds of services use and the commands don't include adding that flag, it only runs npm install and anything else errors out Sent from my T-Mobile 5G Device Get Outlook for Android<https://aka.ms/AAb9ysg>

…

________________________________ From: Victor Vincent ***@***.***> Sent: Friday, June 30, 2023 12:57:39 AM To: ava/use-http ***@***.***> Cc: Tanner Summers ***@***.***>; Comment ***@***.***> Subject: Re: [ava/use-http] React 18 StrictMode (Issue #369) Lol, that's something I never heard of. For me 9 out of 10 projects have to use --legacy-peer-deps. Just because a package hasn't been updated since the release of npm v7 it doesn't mean it's a security risk. — Reply to this email directly, view it on GitHub<#369 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ACDUUD6O3QNK3564LKFGXX3XNZTFHANCNFSM5WTDVHPA>. You are receiving this because you commented.Message ID: ***@***.***>

wintercounter · 2023-06-30T13:06:26Z

So is it a strict rule, or you just cannot modify the command the CI will run? Because in that case, you can just add in .npmrc until this gets resolved.

…

On Fri, Jun 30, 2023 at 2:36 PM Tanner Summers ***@***.***> wrote: I'm not saying your wrong, but I am gonna say we don't have much of a choice. It's a pipeline hundreds of services use and the commands don't include adding that flag, it only runs npm install and anything else errors out Sent from my T-Mobile 5G Device Get Outlook for Android<https://aka.ms/AAb9ysg> ________________________________ From: Victor Vincent ***@***.***> Sent: Friday, June 30, 2023 12:57:39 AM To: ava/use-http ***@***.***> Cc: Tanner Summers ***@***.***>; Comment ***@***.***> Subject: Re: [ava/use-http] React 18 StrictMode (Issue #369) Lol, that's something I never heard of. For me 9 out of 10 projects have to use --legacy-peer-deps. Just because a package hasn't been updated since the release of npm v7 it doesn't mean it's a security risk. — Reply to this email directly, view it on GitHub< #369 (comment)>, or unsubscribe< https://github.com/notifications/unsubscribe-auth/ACDUUD6O3QNK3564LKFGXX3XNZTFHANCNFSM5WTDVHPA>. You are receiving this because you commented.Message ID: ***@***.***> — Reply to this email directly, view it on GitHub <#369 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAHLJQGZ6CID6NESEGHY5LTXN3B3TANCNFSM5WTDVHPA> . You are receiving this because you commented.Message ID: ***@***.***>

TannerS · 2023-06-30T13:08:59Z

Far as I know the DevOps team controls the pipeline for hundreds of teams so we have no say in how it's ran, and we also don't control the npmrc file, locally yes but in the pipeline it's all DevOps configs. I really love this lib and don't wanna abandon it but it's the only dep blocking multiple of our services from going to react 18. That is why I was curious on if there is maybe an estimated time Sent from my T-Mobile 5G Device Get Outlook for Android<https://aka.ms/AAb9ysg>

________________________________ From: Victor Vincent ***@***.***> Sent: Friday, June 30, 2023 8:06:37 AM To: ava/use-http ***@***.***> Cc: Tanner Summers ***@***.***>; Comment ***@***.***> Subject: Re: [ava/use-http] React 18 StrictMode (Issue #369) So is it a strict rule, or you just cannot modify the command the CI will run? Because in that case, you can just add in .npmrc until this gets resolved.

On Fri, Jun 30, 2023 at 2:36 PM Tanner Summers ***@***.***> wrote: I'm not saying your wrong, but I am gonna say we don't have much of a choice. It's a pipeline hundreds of services use and the commands don't include adding that flag, it only runs npm install and anything else errors out Sent from my T-Mobile 5G Device Get Outlook for Android<https://aka.ms/AAb9ysg> ________________________________ From: Victor Vincent ***@***.***> Sent: Friday, June 30, 2023 12:57:39 AM To: ava/use-http ***@***.***> Cc: Tanner Summers ***@***.***>; Comment ***@***.***> Subject: Re: [ava/use-http] React 18 StrictMode (Issue #369) Lol, that's something I never heard of. For me 9 out of 10 projects have to use --legacy-peer-deps. Just because a package hasn't been updated since the release of npm v7 it doesn't mean it's a security risk. — Reply to this email directly, view it on GitHub< #369 (comment)>, or unsubscribe< https://github.com/notifications/unsubscribe-auth/ACDUUD6O3QNK3564LKFGXX3XNZTFHANCNFSM5WTDVHPA>. You are receiving this because you commented.Message ID: ***@***.***> — Reply to this email directly, view it on GitHub <#369 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAHLJQGZ6CID6NESEGHY5LTXN3B3TANCNFSM5WTDVHPA> . You are receiving this because you commented.Message ID: ***@***.***>

— Reply to this email directly, view it on GitHub<#369 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ACDUUDYNXIH7XYHUJ2QMYCLXN3FN3ANCNFSM5WTDVHPA>. You are receiving this because you commented.Message ID: ***@***.***>

zvi1977 changed the title ~~React 18~~ React 18 StrictMode May 29, 2022

krishnasaga mentioned this issue Mar 9, 2023

React 18 not supported? #386

Open

marcod1419 mentioned this issue Apr 11, 2023

Support react 18 peer dependency #387

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

React 18 StrictMode #369

React 18 StrictMode #369

zvi1977 commented May 22, 2022

t3db0t commented May 24, 2022

wintercounter commented May 28, 2022

zvi1977 commented May 29, 2022

krishnasaga commented Dec 3, 2022

krishnasaga commented Dec 4, 2022 •

edited

Loading

enriquemorenotent commented Jan 20, 2023

krishnasaga commented Jan 23, 2023

enriquemorenotent commented Jan 23, 2023

krishnasaga commented Jan 23, 2023

enriquemorenotent commented Jan 23, 2023

flo-sch commented Jan 24, 2023 •

edited

Loading

enriquemorenotent commented Jan 24, 2023

flo-sch commented Jan 24, 2023

krishnasaga commented Mar 13, 2023

alex-cory commented Mar 14, 2023

krishnasaga commented Apr 9, 2023 •

edited

Loading

csvan commented Apr 25, 2023

TannerS commented Jun 29, 2023

wintercounter commented Jun 30, 2023

TannerS commented Jun 30, 2023 via email

wintercounter commented Jun 30, 2023 via email

TannerS commented Jun 30, 2023 via email

React 18 StrictMode #369

React 18 StrictMode #369

Comments

zvi1977 commented May 22, 2022

t3db0t commented May 24, 2022

wintercounter commented May 28, 2022

zvi1977 commented May 29, 2022

krishnasaga commented Dec 3, 2022

krishnasaga commented Dec 4, 2022 • edited Loading

enriquemorenotent commented Jan 20, 2023

krishnasaga commented Jan 23, 2023

enriquemorenotent commented Jan 23, 2023

krishnasaga commented Jan 23, 2023

enriquemorenotent commented Jan 23, 2023

flo-sch commented Jan 24, 2023 • edited Loading

enriquemorenotent commented Jan 24, 2023

flo-sch commented Jan 24, 2023

krishnasaga commented Mar 13, 2023

alex-cory commented Mar 14, 2023

krishnasaga commented Apr 9, 2023 • edited Loading

csvan commented Apr 25, 2023

TannerS commented Jun 29, 2023

wintercounter commented Jun 30, 2023

TannerS commented Jun 30, 2023 via email

wintercounter commented Jun 30, 2023 via email

TannerS commented Jun 30, 2023 via email

krishnasaga commented Dec 4, 2022 •

edited

Loading

flo-sch commented Jan 24, 2023 •

edited

Loading

krishnasaga commented Apr 9, 2023 •

edited

Loading