Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[com4FlowPy]: Add benchmark tests for FlowPy #1005

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

PaulaSp3
Copy link
Contributor

@PaulaSp3 PaulaSp3 commented Jul 15, 2024

Add two benchmark tests for FlowPy (in 1. real topography: Arzler Alm, 2. generic topography, as in FlowPy-paper)

runsStandardTestsCom4FlowPy.py executes FlowPy with standard parameters in both topgraphys and compares the results with 'true' results (from the original master branch/ Flow-Py paper results)

AIMEC analyses (as in runsStandardTestsCom1DFA.py) are not done here.

@PaulaSp3 PaulaSp3 requested a review from ahuber-bfw July 15, 2024 09:17
@pep8speaks
Copy link

pep8speaks commented Jul 15, 2024

Hello @PaulaSp3! Thanks for updating this PR.

Line 484:13: E265 block comment should start with '# '
Line 483:13: E265 block comment should start with '# '
Line 321:121: E501 line too long (121 > 120 characters)
Line 251:5: E722 do not use bare 'except'

Line 129:33: W292 no newline at end of file
Line 126:121: E501 line too long (169 > 120 characters)
Line 34:121: E501 line too long (148 > 120 characters)

Comment last updated at 2024-09-23 11:17:04 UTC

@PaulaSp3 PaulaSp3 self-assigned this Jul 15, 2024
@PaulaSp3 PaulaSp3 added the testing pytest etc label Jul 15, 2024
@PaulaSp3 PaulaSp3 changed the title Add benchmark tests for FlowPy [com4FlowPy]: Add benchmark tests for FlowPy Jul 16, 2024
@PaulaSp3 PaulaSp3 force-pushed the PS_FP_benchmarks branch 4 times, most recently from 5bb3532 to 20e2330 Compare September 16, 2024 09:29
benchmark tests for FP

pep8speaks

small bug

update bug fix

add statement that rasters are close

Add relative comparison (when rasters are close)

Write message in report file

fix minor bug

change to array

reduce lines
Copy link

codeclimate bot commented Sep 23, 2024

Code Climate has analyzed commit c730204 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 0.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 69.6% (0.0% change).

View more on Code Climate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing pytest etc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants